Bug#835056: maven-repo-helper: Cannot ignore module if referencing pom is not in parent folder

[Christopher Hoskin]

Package: maven-repo-helper
Version: 1.9.2
Severity: normal

Dear Maintainer,

Consider the structure

./pom.xml
./module1/pom.xml
./module1/submodule1a/pom.xml

./pom.xml contains:

<module>module1/submodule1a</module>

./module1/submodule1a/pom.xml contains:

  <parent>
    ...
    <relativePath>../../pom.xml</relativePath>
  </parent>

./module1/pom.xml does not reference submodule1a as a module.

In debian/<packagename>.poms we add:

module1/submodule1a/pom.xml --ignore

in src/main/java/org/debian/maven/repo/POMTransformer.java, discoverModulesToIgnore() it is assumed that the parent POM is always in ../:

            public void ignorePOM(File pomFile) throws Exception {
                File parentPom = new File(pomFile.getParentFile().getParentFile(), "pom.xml");
                addIgnoreModule(parentPom, pomFile.getParentFile().getName());
            }

and no use is made of the relativePath. Therefore the module is not ignored.

Thank you.

Christopher Hoskin



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages maven-repo-helper depends on:
ii  default-jre-headless [java2-runtime-headless]    2:1.8-57
ii  gcj-5-jre-headless [java2-runtime-headless]      5.4.1-1
ii  libstax-java                                     1.2.0-3
ii  openjdk-8-jre-headless [java2-runtime-headless]  8u102-b14.1-2

Versions of packages maven-repo-helper recommends:
ii  debhelper  9.20160814

Versions of packages maven-repo-helper suggests:
ii  maven-debian-helper  2.1.1

-- no debconf information