Bug#878103: maven-debian-helper: Wrong package name for -doc packages

[Christopher Hoskin]

Package: maven-debian-helper
Version: 2.2.5
Severity: normal

Dear Maintainer,

Following commit cafc9403b0da58c789ed95e5d8ff3b165bcde76f, when the
DEB_BUILD_OPTIONS variable does not include nodoc, maven-debian-helper
mistakenly uses "1" as the packagename instead of the actual name of the doc
package. A consequence of this is that a file debian/1.substvar is created
instead of debian/<name>-doc.substvar.

The reason for this appears to be that share/perl/maven.pm has the following
modification:

-	$this->{doc_package} = (grep /-doc$/, @packages)[0];
+	$this->{doc_package} = (grep /-doc$/, @packages)[0] && (get_buildoption("nodoc") != 1);

When the DEB_BUILD_OPTIONS variable does not include nodoc, get_buildoption("nodoc") returns undef and (get_buildoption("nodoc") != 1) evaluates to 1. However,
(grep /-doc$/, @packages)[0] && (get_buildoption("nodoc") != 1) evaluates to 1, not
to (grep /-doc$/, @packages)[0].

Christopher

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.13.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages maven-debian-helper depends on:
ii  default-jdk                     2:1.8-59
ii  default-jdk-headless            2:1.8-59
ii  libmaven-clean-plugin-java      3.0.0-2
ii  libmaven-compiler-plugin-java   3.6.2-2
ii  libmaven-jar-plugin-java        3.0.2-2
ii  libmaven-resources-plugin-java  3.0.2-1
ii  libmaven-site-plugin-java       3.6-1
ii  libplexus-velocity-java         1.2-3
ii  libsurefire-java                2.20.1-3
ii  libxml2-utils                   2.9.4+dfsg1-4
ii  maven                           3.5.0-6
ii  maven-repo-helper               1.9.2
ii  unzip                           6.0-21
ii  velocity                        1.7-5

maven-debian-helper recommends no packages.

Versions of packages maven-debian-helper suggests:
ii  apt-file                      3.1.4
ii  libmaven-javadoc-plugin-java  3.0.0~M1-4
ii  licensecheck                  3.0.31-2
ii  subversion                    1.9.7-2

-- no debconf information