Bug#893547: ant: please do not emit --ignore-source-errors on Java 9

[Ole Streicher]

Hi Tony,


On 20.03.2018 05:20, tony mancill wrote:
> I'm in the midst of preparing an update for ant.  Is there any context
> in which we want to add "--ignore-source-errors" to the ant javadoc
> task, or should this patch [1] be removed entirely?
>

I am not familar with ant, so I can't recommend here. The failure seems
to not generally appear, but only on specific targets.

This is the snippet that produces the error:

    <javadoc doclet="uk.ac.starlink.ttools.build.HtmlDoclet"
             docletpathref="classpath"
             failonerror="true"
             public="true"
             additionalparam="-headings"
             destdir="${build.javadocs}"
             sourcepath="${java.dir}"
             packagenames="uk.ac.starlink.ttools.func"
             classpathref="classpath"
             encoding="cp1252"/>

while this one (from another package, starjava-pal) works fine:

    <javadoc useexternalfile="yes"
             destdir="${dist.javadocs}"
             author="true"
             version="true"
             locale="en"
             windowtitle="${Name} API"
             doctitle="${Name}"
             defaultexcludes="yes"
             source="${source.version}"
             classpathref="classpath">

So, it may have something to do with the doclet.

Best

Ole