Bug#896439: gradle-debian-helper points to an invalid java api directory

[Tiago Daitx]

Markus and Emmanuel,

Thanks for the replies, I got the feedback that I needed.

On Sat, Apr 21, 2018 at 3:16 PM, Markus Koschany <apo at debian.org> wrote:
>
> Am 21.04.2018 um 19:57 schrieb Emmanuel Bourg:
>> Hi Tiago,
>>
>> I don't think gradle-debian-helper should depend on default-jdk-doc by
>> default, this is a rather big dependency and it's preferable to keep it
>> optional to speed up the builds a bit. I think the packages using
>> gradle-debian-helper should instead depend on default-jdk-doc if they
>> build a javadoc package. That's what most packages building a javadoc
>> already do.

Indeed, the package size is indeed pretty big. Given that it's better
to preserve the current behavior.

>> As for changing the path to the JDK doc why not, but I don't really
>> understand the benefit. It seems both URLs are currently in use, with
>> /usr/share/doc/default-jdk-doc/api being more popular than
>> /usr/share/doc/default-jdk/api despite the longer path.
>
> By the way since Debian Policy 3.9.7 it is recommended to install
> additional documentation via -doc packages into /usr/share/doc/pkg and
> no longer /usr/share/doc/pkg-doc. This is also enforced with
> debhelper/compat >= 11. If we were consequent then we should use
> /usr/share/doc/default-jdk/api everywhere.

If that is enforced for debhelper/compat >=11 than java-common does
not seems to be following the rules. What about updating java-common
to use the /usr/share/doc/default-jdk path? If so, should we keep
links (for the existing files) in the /usr/share/doc/default-jdk-doc/
or drop that path altogether?


Thanks for the review!


-- 
Tiago Stürmer Daitx
Software Engineer
tiago.daitx at canonical.com

PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com)
Fingerprint = 45D0 FE5A 8109 1E91 866E  8CA4 1931 8D5E F5B2 13BE