Bug#945917: jh_build: JH_JAR_EXTRA is ignored

[tony mancill]

On Sun, Dec 01, 2019 at 01:34:08AM +0000, Frédéric Perrin wrote:
> Package: javahelper
> Version: 0.72.9
> Severity: normal
> 
> Dear Maintainer,
> 
> Option JH_JAR_EXTRA is ignored by jh_build. When setting the script
> variable from the environment, the code looks at the existing value,
> rather than the env. IOW, it should be:
> 
> diff -U0 jh_build.orig jh_build
> --- jh_build.orig	2019-12-01 00:25:24.162770395 +0000
> +++ jh_build	2019-12-01 00:35:58.528043183 +0000
> @@ -121 +121 @@
> - at JH_JAR_EXTRA = split(' ', $ENV{'JH_JAR_EXTRA'}) if @JH_JAR_EXTRA;
> + at JH_JAR_EXTRA = split(' ', $ENV{'JH_JAR_EXTRA'}) if $ENV{JH_JAR_EXTRA};

Indeed - thank you for spotting this and providing a patch.  This was
introduced when jh_build was ported from shell to perl, as the env var
used to be interpolated directly [1].

We will address this in the next upload.

Thanks!
tony

[1] https://salsa.debian.org/java-team/javatools/commit/b54816d93fd2e70b25902bfa97e890f3c87f8b8b#778240bd31b577096d826a2f46944192b1498411_170_253
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-java-maintainers/attachments/20191204/0ce0a92f/attachment.sig>