Bug#924653: jh_build: wrong path when 'jarfile' argument is given with no path

[Gilles Filippini]

Package: javahelper
Version: 0.72.5
Severity: serious
Justification: make other packages FTBFS

Hi,

Recent uploads of javahelper introduced a jh_build regression regarding
the handling of the 'jarfile' parameter.

See this [1] reproducibility build log for mac-widgets.

[1] https://tests.reproducible-builds.org/debian/rbuild/unstable/amd64/mac-widgets_0.10.0+svn416-dfsg1-3.rbuild.log.gz

jh_build is called from debian/rules with:
	jh_build mac_widgets.jar source demo

And the build fails with:
java.nio.file.NoSuchFileException: /tmp/mac_widgets.jar6488846790867776985.jar -> /build/1st/mac-widgets-0.10.0+svn416-dfsg1/mac_widgets.jar/mac_widgets.jar
                                                                                                                             ^^^^^^^^^^^^^^^

It seems jh_build computes a wrong path when the 'jarfile' argument is given with no path.

Any of these workarounds works, but mac-widgets might not be the only source package using jh_build this way:
	jh_build ./mac_widgets.jar source demo
	jh_build $(CURDIR)/mac_widgets.jar source demo

Thanks,

_g.

-- System Information:
Debian Release: buster/sid
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-2-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages javahelper depends on:
ii  bsdmainutils         11.1.2+b1
ii  dctrl-tools          2.24-3
ii  debhelper            12.1.1
ii  devscripts           2.19.3
ii  dpkg-dev             1.19.5
ii  libarchive-zip-perl  1.64-1
ii  perl                 5.28.1-4

javahelper recommends no packages.

Versions of packages javahelper suggests:
pn  cvs       <none>
ii  gawk      1:4.2.1+dfsg-1
ii  tofrodos  1.7.13+ds-4

-- no debconf information