checker-framework-java_3.0.1+ds-1~exp2_amd64.changes REJECTED

[Olek Wojnar]

Hi Sean and thanks for the summary. That's quite the thorough review!
Fortunately, I think I can easily address all of your concerns.

On Wed, Oct 21, 2020 at 9:00 PM Sean Whitton <
ftpmaster at ftp-master.debian.org> wrote:

>
> +----------------------+
> |   REJECT reasoning   |
> +----------------------+
>
> I found various .class files where it is not clear we have the Java source
> code for them.


The only three .class files I found in the source code were for a bug test
case at:
checker/jtreg/nullness/issue2173/*

Is that what you were concerned about? If so, you can consider that problem
solved as I have removed them from the +ds1 version of the package.

In addition, one of our trainees found the following:
>
> Contains code with a declared upstream of non-free docs.
>

Is this the
checker/src/testannotations/java/javax/validation/constraints/NotNull.java
file? If so, please see below.


> Various missing licenses.
>
> checker/src/testannotations/java/android/* is copyright 2013, The Android
> Open Source Project, Apache-2.0
>
> checker/src/testannotations/java/edu/umd/cs/findbugs/annotations/* is
> copyright 2005, University of Maryland, LGPL-2.1+
>
> checker/src/testannotations/java/javax/validation/constraints/* is
> copyright Oracle and NONFREE
>
> checker/src/testannotations/java/net/jcip/annotations/* is (c) 2005 Brian
> Goetz and Tim Peierls, CC-BY-2.5
>
> checker/src/testannotations/java/org/eclipse/jdt/annotation/* is (c) the
> Eclipse Foundation, EPL-2.0
>
> checker/src/testannotations/java/org/eclipse/jgit/annotations/* is (c) The
> Eclipse Foundation, BSD-3-Clause
>
> checker/src/testannotations/java/org/jetbrains/annotations/* is (c)
> JetBrains s.r.o, Apache-2.0
>
> checker/src/testannotations/java/org/netbeans/api/annotations/common/* is
> (c) Apache Software Foundation, Apache-2.0
>
> checker/src/testannotations/java/org/springframework/lang/* is Copyright
> 2002-2019 the original author or authors., Apache-2.0
>

Upstream has clarified [1] that those are clean-room reimplementations of
the corresponding specifications. They have added the clarification to the
relevant source code files and I added a clarification note in d/copyright
referencing the upstream change.

dataflow/manual/*.sty is (c) various, LPPL-1.3+ and embedded copies
>

Good point. Also removed in the +ds1 version. No loss since we're not even
packaging dataflow right now.

Given the relatively minor fixes and the fact that this is blocking Bazel,
would it be possible for someone to take a quick look at the fixed version
that I just uploaded? [2] Thank you!

-Olek

[1] https://github.com/typetools/checker-framework/issues/3819
[2]
https://ftp-master.debian.org/new/checker-framework-java_3.0.1+ds1-1~exp1.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-java-maintainers/attachments/20201022/8d05c0c7/attachment-0001.html>