Bug#1003972: marked as done (libphonenumber: New upstream release - please update)

[tony mancill]

On Fri, Jan 28, 2022 at 09:42:43PM -0700, Neil Mayhew wrote:
> On 2022-01-28 08:29, Neil Mayhew wrote:
> > It looks like geocoding_data.cc is truncated and my working hypothesis
> > is that it's still in the process of being generated, which in turn is
> > due to race condition in the parallel build. This could explain why it
> > built successfully on some architectures and not others.
> 
> I'm able to reproduce the build failure in a non-Debian build on my local
> machine with -j16. I can confirm that this is due to a race condition in the
> build. The generated source file is created three times in parallel by
> different make threads, and one of those threads tries to compile it while
> another thread is in the middle of rewriting it.
> 
> Based on some info in the cmake documentation[1] I think this is a bug in
> the way the build is defined:
> 
>> Do not list the output in more than one independent target that may build
>> in parallel or the two instances of the rule may conflict
> 
> [1]: https://cmake.org/cmake/help/latest/command/add_custom_command.html

Thank you for getting to the bottom of it and sharing your findings.

> I'll work with upstream to get this fixed. In the meantime, I'm confident
> that using parallel=1 in the Debian build is the right solution for the
> package.

Cool.  I gave it a try in [2] and bit the builds look good so far [3].  The
mipsel64 build was (perhaps ironically) successfully with the prior
upload, so I am confident too.  I will (re)close the bug once those
mipsel builds complete.

> Thanks very much for working to get this release packaged.

Glad to be of assistance.  It was fortunate that abseil [4] is already
packaged for Debian, and that libphonenumber does appear to require a
more recent version of it.

By the way, I noticed that 8.12.42 was released a couple days ago [4].
My thought was to let 8.12.41 transition to testing (5 days) before
uploading to unstable again, in case that impacts whether/when Ubuntu
picks up the update.  Let me know if you know otherwise.

Cheers,
tony

[2] https://salsa.debian.org/debian/libphonenumber/-/commit/aa17dbeb4bbac77ca9cd109101a8a1e1a2514858
[3] https://buildd.debian.org/status/package.php?p=libphonenumber
[4] https://tracker.debian.org/pkg/abseil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-java-maintainers/attachments/20220128/e6e4422f/attachment.sig>