Bug#1043616: commons-httpclient: Fails to build source after successful build

[Lucas Nussbaum]

Source: commons-httpclient
Version: 3.1-16
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package commons-httpclient
> dpkg-buildpackage: info: source version 3.1-16
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Emmanuel Bourg <ebourg at apache.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --with javahelper --buildsystem=maven
>    dh_auto_clean -O--buildsystem=maven
> 	mh_patchpoms -plibcommons-httpclient-java --debian-build --keep-pom-version --maven-repo=/<<PKGBUILDDIR>>/debian/maven-repo
> 	/usr/lib/jvm/default-java/bin/java -noverify -cp /usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven -Dmaven.multiModuleProjectDirectory=/<<PKGBUILDDIR>> -Dclassworlds.conf=/etc/maven/m2-debian.conf -Dproperties.file.manual=/<<PKGBUILDDIR>>/debian/maven.properties org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-debian.xml -Ddebian.dir=/<<PKGBUILDDIR>>/debian -Dmaven.repo.local=/<<PKGBUILDDIR>>/debian/maven-repo --batch-mode clean
> OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
> [INFO] Scanning for projects...
> [INFO] 
> [INFO] ---------------< commons-httpclient:commons-httpclient >----------------
> [INFO] Building HttpClient 3.1
> [INFO] --------------------------------[ jar ]---------------------------------
> [WARNING] The artifact org.apache.maven.plugins:maven-clean-plugin:jar:2.5 has been relocated to org.apache.maven.plugins:maven-clean-plugin:jar:3.2.0
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ commons-httpclient ---
> [INFO] Deleting /<<PKGBUILDDIR>>/target
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  0.440 s
> [INFO] Finished at: 2023-08-12T12:45:08Z
> [INFO] ------------------------------------------------------------------------
> 	bash -c "for dir in \$(find . -name target -type d); do if [ -f \$(echo \$dir | sed -e s/target\$/pom.xml/) ]; then rm -Rf \$dir; fi done"
> 	mh_unpatchpoms -plibcommons-httpclient-java
>    dh_autoreconf_clean -O--buildsystem=maven
>    jh_clean -O--buildsystem=maven
>    dh_clean -O--buildsystem=maven
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building commons-httpclient using existing ./commons-httpclient_3.1.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  commons-httpclient-3.1/docs/authentication.html
>  commons-httpclient-3.1/docs/changelog-report.html
>  commons-httpclient-3.1/docs/charencodings.html
>  commons-httpclient-3.1/docs/cookies.html
>  commons-httpclient-3.1/docs/dependencies.html
>  commons-httpclient-3.1/docs/developer-activity-report.html
>  commons-httpclient-3.1/docs/developerguide.html
>  commons-httpclient-3.1/docs/development-process.html
>  commons-httpclient-3.1/docs/downloads.html
>  commons-httpclient-3.1/docs/exception-handling.html
>  commons-httpclient-3.1/docs/features.html
>  commons-httpclient-3.1/docs/file-activity-report.html
>  commons-httpclient-3.1/docs/index.html
>  commons-httpclient-3.1/docs/issue-tracking.html
>  commons-httpclient-3.1/docs/javadoc-warnings-report.html
>  commons-httpclient-3.1/docs/javadoc.html
>  commons-httpclient-3.1/docs/jdepend-report.html
>  commons-httpclient-3.1/docs/junit-report.html
>  commons-httpclient-3.1/docs/license.html
>  commons-httpclient-3.1/docs/logging.html
>  commons-httpclient-3.1/docs/mail-lists.html
>  commons-httpclient-3.1/docs/maven-reports.html
>  commons-httpclient-3.1/docs/methods.html
>  commons-httpclient-3.1/docs/methods/delete.html
>  commons-httpclient-3.1/docs/methods/get.html
>  commons-httpclient-3.1/docs/methods/head.html
>  commons-httpclient-3.1/docs/methods/multipartpost.html
>  commons-httpclient-3.1/docs/methods/options.html
>  commons-httpclient-3.1/docs/methods/post.html
>  commons-httpclient-3.1/docs/methods/put.html
>  commons-httpclient-3.1/docs/methods/trace.html
>  commons-httpclient-3.1/docs/news.html
>  commons-httpclient-3.1/docs/overview.html
>  commons-httpclient-3.1/docs/performance.html
>  commons-httpclient-3.1/docs/preference-api.html
>  commons-httpclient-3.1/docs/project-info.html
>  commons-httpclient-3.1/docs/proposal.html
>  commons-httpclient-3.1/docs/redirects.html
>  commons-httpclient-3.1/docs/scm-usage.html
>  commons-httpclient-3.1/docs/sslguide.html
>  commons-httpclient-3.1/docs/status.html
>  commons-httpclient-3.1/docs/task-list.html
>  commons-httpclient-3.1/docs/team-list.html
>  commons-httpclient-3.1/docs/threading.html
>  commons-httpclient-3.1/docs/troubleshooting.html
>  commons-httpclient-3.1/docs/tutorial.html
>  commons-httpclient-3.1/docs/userguide.html
>  commons-httpclient-3.1/project.xml
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/commons-httpclient_3.1-16.diff.fc4EHy
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/commons-httpclient_3.1-16_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.