Bug#1043726: castor: Fails to build source after successful build

[Lucas Nussbaum]

Source: castor
Version: 1.3.2-7
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package castor
> dpkg-buildpackage: info: source version 1.3.2-7
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Emmanuel Bourg <ebourg at apache.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --buildsystem=ant --with javahelper --with maven-repo-helper
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> cd src && ant distclean
> Buildfile: /<<PKGBUILDDIR>>/src/build.xml
> 
> clean.tests:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/build/test
> 
> clean.tests.core:
> 
> clean.xmlctf:
> 
> clean.xmlctf:
> 
> clean.cpactf:
> 
> clean.cpaptf:
> 
> clean.tests.codegen:
> 
> clean.tests.schema:
> 
> clean.tests.diff:
> 
> clean.libs:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/newlib
>    [delete] Deleting directory /<<PKGBUILDDIR>>/anttask/lib
>    [delete] Deleting directory /<<PKGBUILDDIR>>/codegen/lib
>    [delete] Deleting directory /<<PKGBUILDDIR>>/core/lib
>    [delete] Deleting directory /<<PKGBUILDDIR>>/cpa/lib
>    [delete] Deleting directory /<<PKGBUILDDIR>>/ddlgen/lib
>    [delete] Deleting directory /<<PKGBUILDDIR>>/diff/lib
>    [delete] Deleting directory /<<PKGBUILDDIR>>/schema/lib
> 
> clean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/build
>    [delete] Deleting directory /<<PKGBUILDDIR>>/dist
> 
> clean.core:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/core/build
> 
> clean.ddlgen:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/ddlgen/build
> 
> clean.cpa:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/cpa/build
> 
> clean.codegen:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/codegen/build
> 
> clean.anttask:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/anttask/build
> 
> clean.cpactf:
> 
> clean.cpaptf:
> 
> clean.examples:
> 
> clean.schema:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/schema/build
> 
> clean.diff:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/diff/build
> 
> distclean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/target
> 
> BUILD SUCCESSFUL
> Total time: 1 second
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--buildsystem=ant
>    jh_clean -O--buildsystem=ant
>    dh_clean -O--buildsystem=ant
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building castor using existing ./castor_1.3.2.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of directory schema/lib
> dpkg-source: warning: ignoring deletion of directory anttask/lib
> dpkg-source: warning: ignoring deletion of directory diff/lib
> dpkg-source: warning: ignoring deletion of directory codegen/lib
> dpkg-source: warning: ignoring deletion of directory ddlgen/lib
> dpkg-source: warning: ignoring deletion of directory core/lib
> dpkg-source: warning: file castor-1.3.2/cpa/target/generated-sources/jjtree/org/castor/cpa/query/ejbql/EjbQL.jj has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/EjbQLParser.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/EjbQLParserConstants.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/EjbQLParserTokenManager.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/EjbQLParserTreeConstants.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/JJTEjbQLParserState.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/Node.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/ParseException.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/SimpleCharStream.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/SimpleNode.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/Token.java
>  castor-1.3.2/cpa/target/generated-sources/javacc/org/castor/cpa/query/ejbql/TokenMgrError.java
>  castor-1.3.2/cpa/target/generated-sources/jjtree/org/castor/cpa/query/ejbql/EjbQL.jj
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/castor_1.3.2-7.diff.WpcAso
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/castor_1.3.2-7_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.