Bug#1043866: antlr: Fails to build source after successful build

[Lucas Nussbaum]

Source: antlr
Version: 2.7.7+dfsg-12
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ----------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package antlr
> dpkg-buildpackage: info: source version 2.7.7+dfsg-12
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by tony mancill <tmancill at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --with maven-repo-helper --with python3
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> cd lib/cpp; /usr/bin/make clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>/lib/cpp'
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >> /usr/bin/make -C lib/cpp/antlr clean                          
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> make[3]: Entering directory '/<<PKGBUILDDIR>>/lib/cpp/antlr'
> make[3]: Nothing to be done for 'clean'.
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/lib/cpp/antlr'
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >> /usr/bin/make -C lib/cpp/src clean                          
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> make[3]: Entering directory '/<<PKGBUILDDIR>>/lib/cpp/src'
> /bin/rm -r -f *.obj *.o *.a  *.lib *.so *.dll *~ /<<PKGBUILDDIR>>/lib/cpp/src/libantlr.a
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/lib/cpp/src'
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/lib/cpp'
> find -name Makefile | xargs rm -f
> rm -rf lib/python/build
> rm -rf scripts/run-antlr
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building antlr using existing ./antlr_2.7.7+dfsg.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file antlr.jar, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file antlr/Version.java, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file scripts/install-sh, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file scripts/config.guess, use --include-removal to override
> dpkg-source: warning: file antlr-2.7.7+dfsg/lib/python/antlr.egg-info/SOURCES.txt has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  antlr-2.7.7+dfsg/lib/python/antlr.egg-info/PKG-INFO
>  antlr-2.7.7+dfsg/lib/python/antlr.egg-info/SOURCES.txt
>  antlr-2.7.7+dfsg/lib/python/antlr.egg-info/dependency_links.txt
>  antlr-2.7.7+dfsg/lib/python/antlr.egg-info/top_level.txt
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/antlr_2.7.7+dfsg-12.diff.8TeeTH
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/antlr_2.7.7+dfsg-12_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.