Bug#1046059: spatial4j: Fails to build source after successful build

[Lucas Nussbaum]

Source: spatial4j
Version: 0.8-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package spatial4j
> dpkg-buildpackage: info: source version 0.8-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	mh_patchpoms -plibspatial4j-java --debian-build --keep-pom-version --maven-repo=/<<PKGBUILDDIR>>/debian/maven-repo
> 	/usr/lib/jvm/default-java/bin/java -noverify -cp /usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven -Dmaven.multiModuleProjectDirectory=/<<PKGBUILDDIR>> -Dclassworlds.conf=/etc/maven/m2-debian.conf -Dproperties.file.manual=/<<PKGBUILDDIR>>/debian/maven.properties org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-debian.xml -Ddebian.dir=/<<PKGBUILDDIR>>/debian -Dmaven.repo.local=/<<PKGBUILDDIR>>/debian/maven-repo --batch-mode clean
> OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
> [INFO] Scanning for projects...
> [INFO] 
> [INFO] ----------------< org.locationtech.spatial4j:spatial4j >----------------
> [INFO] Building Spatial4J 0.8
> [INFO] -------------------------------[ bundle ]-------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ spatial4j ---
> [INFO] Deleting /<<PKGBUILDDIR>>/target
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  0.747 s
> [INFO] Finished at: 2023-08-12T13:14:24Z
> [INFO] ------------------------------------------------------------------------
> 	bash -c "for dir in \$(find . -name target -type d); do if [ -f \$(echo \$dir | sed -e s/target\$/pom.xml/) ]; then rm -Rf \$dir; fi done"
> 	mh_unpatchpoms -plibspatial4j-java
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building spatial4j using existing ./spatial4j_0.8.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  spatial4j-0.8/src/main/java/org/locationtech/spatial4j/io/jackson/PackageVersion.java
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/spatial4j_0.8-1.diff.yQHGEh
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/spatial4j_0.8-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.