Bug#1048200: saaj-ri: Fails to build source after successful build

[Lucas Nussbaum]

Source: saaj-ri
Version: 1.4.1-1.1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package saaj-ri
> dpkg-buildpackage: info: source version 1.4.1-1.1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Holger Levsen <holger at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --buildsystem=maven
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_auto_clean -- -f saaj-ri/pom.xml
> 	mh_patchpoms -plibsaaj-ri-java --debian-build --keep-pom-version --maven-repo=/<<PKGBUILDDIR>>/debian/maven-repo
> 	/usr/lib/jvm/default-java/bin/java -noverify -cp /usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven -Dmaven.multiModuleProjectDirectory=/<<PKGBUILDDIR>> -Dclassworlds.conf=/etc/maven/m2-debian.conf -Dproperties.file.manual=/<<PKGBUILDDIR>>/debian/maven.properties org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-debian.xml -Ddebian.dir=/<<PKGBUILDDIR>>/debian -Dmaven.repo.local=/<<PKGBUILDDIR>>/debian/maven-repo --batch-mode -f saaj-ri/pom.xml
> OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
> [INFO] Scanning for projects...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  0.065 s
> [INFO] Finished at: 2023-08-12T12:24:41Z
> [INFO] ------------------------------------------------------------------------
> [ERROR] No goals have been specified for this build. You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/NoGoalSpecifiedException
> 	bash -c "for dir in \$(find . -name target -type d); do if [ -f \$(echo \$dir | sed -e s/target\$/pom.xml/) ]; then rm -Rf \$dir; fi done"
> 	mh_unpatchpoms -plibsaaj-ri-java
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--buildsystem=maven
>    dh_clean -O--buildsystem=maven
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building saaj-ri using existing ./saaj-ri_1.4.1.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: file saaj-ri-1.4.1/saaj-ri/src/test/mime/data/custom_type_sent.ctp has no final newline (either original or modified version)
> dpkg-source: error: cannot represent change to saaj-ri/src/test/mime/data/headers.txt: binary file contents changed
> dpkg-source: error: add saaj-ri/src/test/mime/data/headers.txt in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: error: cannot represent change to saaj-ri/src/test/mime/data/image_sent.png: binary file contents changed
> dpkg-source: error: add saaj-ri/src/test/mime/data/image_sent.png in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: error: cannot represent change to saaj-ri/src/test/mime/data/java_logo_sent.jpg: binary file contents changed
> dpkg-source: error: add saaj-ri/src/test/mime/data/java_logo_sent.jpg in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: warning: file saaj-ri-1.4.1/saaj-ri/src/test/mime/data/message.txt has no final newline (either original or modified version)
> dpkg-source: warning: file saaj-ri-1.4.1/saaj-ri/src/test/mime/data/saving.cnt has no final newline (either original or modified version)
> dpkg-source: warning: file saaj-ri-1.4.1/saaj-ri/src/test/mime/data/saving_text.cnt has no final newline (either original or modified version)
> dpkg-source: error: unrepresentable changes to source
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/saaj-ri_1.4.1-1.1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.