Bug#1048582: libsweble-wikitext-java: Fails to build source after successful build

[Lucas Nussbaum]

Source: libsweble-wikitext-java
Version: 3.1.9-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libsweble-wikitext-java
> dpkg-buildpackage: info: source version 3.1.9-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean
>    dh_auto_clean
> 	mh_patchpoms -plibsweble-wikitext-java --debian-build --keep-pom-version --maven-repo=/<<PKGBUILDDIR>>/debian/maven-repo
> 	/usr/lib/jvm/default-java/bin/java -noverify -cp /usr/share/maven/boot/plexus-classworlds-2.x.jar -Dmaven.home=/usr/share/maven -Dmaven.multiModuleProjectDirectory=/<<PKGBUILDDIR>> -Dclassworlds.conf=/etc/maven/m2-debian.conf -Dproperties.file.manual=/<<PKGBUILDDIR>>/debian/maven.properties org.codehaus.plexus.classworlds.launcher.Launcher -s/etc/maven/settings-debian.xml -Ddebian.dir=/<<PKGBUILDDIR>>/debian -Dmaven.repo.local=/<<PKGBUILDDIR>>/debian/maven-repo --batch-mode clean
> OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
> [INFO] Scanning for projects...
> [WARNING] 
> [WARNING] Some problems were encountered while building the effective model for org.sweble.wikitext:swc-parser-lazy:jar:3.1.9
> [WARNING] 'build.plugins.plugin.version' for com.google.code.maven-replacer-plugin:replacer is missing. @ line 116, column 12
> [WARNING] 
> [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
> [WARNING] 
> [WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
> [WARNING] 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Build Order:
> [INFO] 
> [INFO] Sweble Parent                                                      [pom]
> [INFO] Sweble Wikitext Components Parent                                  [pom]
> [INFO] SWC - Sweble Wikitext Parser                                       [jar]
> [INFO] 
> [INFO] ----------------------< org.sweble:sweble-parent >----------------------
> [INFO] Building Sweble Parent 3.1.9                                       [1/3]
> [INFO] --------------------------------[ pom ]---------------------------------
> [WARNING] The artifact org.apache.maven.plugins:maven-clean-plugin:jar:2.5 has been relocated to org.apache.maven.plugins:maven-clean-plugin:jar:3.2.0
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ sweble-parent ---
> [INFO] Deleting /<<PKGBUILDDIR>>/target
> [INFO] 
> [INFO] -------< org.sweble.wikitext:sweble-wikitext-components-parent >--------
> [INFO] Building Sweble Wikitext Components Parent 3.1.9                   [2/3]
> [INFO] --------------------------------[ pom ]---------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ sweble-wikitext-components-parent ---
> [INFO] Deleting /<<PKGBUILDDIR>>/sweble-wikitext-components-parent/target
> [INFO] 
> [INFO] ----------------< org.sweble.wikitext:swc-parser-lazy >-----------------
> [INFO] Building SWC - Sweble Wikitext Parser 3.1.9                        [3/3]
> [INFO] --------------------------------[ jar ]---------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ swc-parser-lazy ---
> [INFO] Deleting /<<PKGBUILDDIR>>/sweble-wikitext-components-parent/swc-parser-lazy/target
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary for Sweble Parent 3.1.9:
> [INFO] 
> [INFO] Sweble Parent ...................................... SUCCESS [  0.085 s]
> [INFO] Sweble Wikitext Components Parent .................. SUCCESS [  0.003 s]
> [INFO] SWC - Sweble Wikitext Parser ....................... SUCCESS [  0.042 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time:  0.254 s
> [INFO] Finished at: 2023-08-12T13:08:17Z
> [INFO] ------------------------------------------------------------------------
> 	bash -c "for dir in \$(find . -name target -type d); do if [ -f \$(echo \$dir | sed -e s/target\$/pom.xml/) ]; then rm -Rf \$dir; fi done"
> 	mh_unpatchpoms -plibsweble-wikitext-java
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libsweble-wikitext-java using existing ./libsweble-wikitext-java_3.1.9.orig.tar.gz
> dpkg-source: info: local changes detected, the modified files are:
>  libsweble-wikitext-java-3.1.9/sweble-wikitext-components-parent/swc-parser-lazy/src/main/java/org/sweble/wikitext/parser/parser/RatsWikitextParser.java
>  libsweble-wikitext-java-3.1.9/sweble-wikitext-components-parent/swc-parser-lazy/src/main/java/org/sweble/wikitext/parser/preprocessor/RatsWikitextPreprocessor.java
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libsweble-wikitext-java_3.1.9-2.diff.blsP1T
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libsweble-wikitext-java_3.1.9-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.