Bug#1048792: ognl: Fails to build source after successful build

[Lucas Nussbaum]

Source: ognl
Version: 2.7.3-7
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package ognl
> dpkg-buildpackage: info: source version 2.7.3-7
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --with maven-repo-helper
>    dh_auto_clean
> 	ant -propertyfile ./debian/ant.properties clean
> Buildfile: /<<PKGBUILDDIR>>/build.xml
> 
> init:
>    [tstamp] Honouring environment variable SOURCE_DATE_EPOCH which has been set to 1524081751
> 
> clean:
>    [delete] Deleting directory /<<PKGBUILDDIR>>/build
>    [delete] Deleting directory /<<PKGBUILDDIR>>/dist
> 
> BUILD SUCCESSFUL
> Total time: 0 seconds
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building ognl using existing ./ognl_2.7.3.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: file ognl-2.7.3/src/java/ognl/ognl.jj has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  ognl-2.7.3/src/java/ognl/JJTOgnlParserState.java
>  ognl-2.7.3/src/java/ognl/JavaCharStream.java
>  ognl-2.7.3/src/java/ognl/OgnlParser.java
>  ognl-2.7.3/src/java/ognl/OgnlParserConstants.java
>  ognl-2.7.3/src/java/ognl/OgnlParserTokenManager.java
>  ognl-2.7.3/src/java/ognl/OgnlParserTreeConstants.java
>  ognl-2.7.3/src/java/ognl/ParseException.java
>  ognl-2.7.3/src/java/ognl/Token.java
>  ognl-2.7.3/src/java/ognl/TokenMgrError.java
>  ognl-2.7.3/src/java/ognl/ognl.jj
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/ognl_2.7.3-7.diff.N52wxy
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/ognl_2.7.3-7_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.