Bug#1050944: jtreg6: please make the build reproducible

[tony mancill]

On Thu, Aug 31, 2023 at 02:58:47PM -0700, Vagrant Cascadian wrote:
> On 2023-08-31, Chris Lamb wrote:
> > 2. The jtreg.jar file was being generated with 444 (read-only)
> > permissions. This meant that strip-determinism could not fixup the
> > file modification times of the files within that archive. It was
> > actually printing: "dh_strip_nondeterminism: warning: Ignoring unwritable
> > file: jtreg.jar".
> 
> Curious!
> 
> > --- a/debian/rules	2023-08-31 09:50:06.571624952 -0700
> > --- b/debian/rules	2023-08-31 10:08:31.850276393 -0700
> > @@ -33,3 +33,6 @@
> >  	# Generate the manpages
> >  	JT_HOME=./dist/jtreg/lib/ help2man --name="Regression Test Harness" --help-option="-help all" dist/jtreg/bin/jtdiff > jtdiff.1
> >  	JT_HOME=./dist/jtreg/lib/ help2man --name="Regression Test Harness" --help-option="-help all" dist/jtreg/bin/jtreg > jtreg.1
> > +
> > +execute_before_dh_strip_nondeterminism:
> > +	find  debian/ -type f -name jtreg.jar -print0 | xargs -0tr chmod +w
> 
> Maybe this should be restricted to only make it writeable to the user
> ... e.g. chmod u+w or similar?

Thank you for the patch and the suggestion.  I don't think it makes a
difference, because the jtreg.jar file ends with mod 644 in the binary
package, but I went with the following for symmetry:

execute_before_dh_strip_nondeterminism:
        find  debian/ -type f -name jtreg.jar -print0 | xargs -0tr chmod u+w

execute_after_dh_strip_nondeterminism:
        find  debian/ -type f -name jtreg.jar -print0 | xargs -0tr chmod u-w

diffoscope no longer reports differences between the built and rebuilt jar.

I intend to make a few more packaging changes before the upload, but you
can consider this bug pending.

Thanks,
tony
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-java-maintainers/attachments/20230831/8915135f/attachment.sig>