Bug#1096455: commons-daemon: ftbfs with GCC-15

[Matthias Klose]

Package: src:commons-daemon
Version: 1.0.15-11
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/commons-daemon_1.0.15-11_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
make[3]: *** [../Makedefs:32: help.o] Error 1
make[3]: *** [../Makedefs:32: home.o] Error 1
make[3]: *** [../Makedefs:32: dso-dlfcn.o] Error 1
make[3]: *** [../Makedefs:32: arguments.o] Error 1
In file included from debug.c:18:
jsvc.h:33:5: error: cannot use keyword ‘false’ as enumeration constant
   33 |     false,
      |     ^~~~~
In file included from jsvc-unix.c:18:
jsvc.h:33:5: error: cannot use keyword ‘false’ as enumeration constant
   33 |     false,
      |     ^~~~~
jsvc.h:33:5: note: ‘false’ is a keyword with ‘-std=c23’ onwards
jsvc.h:33:5: note: ‘false’ is a keyword with ‘-std=c23’ onwards
jsvc.h:35:3: error: expected ‘;’, identifier or ‘(’ before ‘bool’
   35 | } bool;
      |   ^~~~
jsvc.h:35:3: error: expected ‘;’, identifier or ‘(’ before ‘bool’
   35 | } bool;
      |   ^~~~
jsvc.h:35:3: warning: useless type name in empty declaration
jsvc.h:35:3: warning: useless type name in empty declaration
make[3]: *** [../Makedefs:32: java.o] Error 1
make[3]: *** [../Makedefs:32: debug.o] Error 1
jsvc-unix.c: In function ‘get_pidf’:
jsvc-unix.c:624:5: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  624 |     lockf(fd, F_LOCK, 0);
      |     ^~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:626:5: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  626 |     lockf(fd, F_ULOCK, 0);
      |     ^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c: In function ‘wait_child’:
jsvc-unix.c:720:9: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  720 |         lockf(fd, F_LOCK, 0);
      |         ^~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:722:9: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  722 |         lockf(fd, F_ULOCK, 0);
      |         ^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c: In function ‘set_output’:
jsvc-unix.c:1018:9: warning: ignoring return value of ‘freopen’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1018 |         freopen("/dev/null", "r", stdin);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:1029:9: warning: ignoring return value of ‘freopen’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1029 |         freopen("/dev/null", "a", stdout);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:1048:9: warning: ignoring return value of ‘freopen’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1048 |         freopen("/dev/null", "a", stderr);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c: In function ‘check_pid’:
jsvc-unix.c:576:9: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  576 |         lockf(fd, F_LOCK, 0);
      |         ^~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:584:17: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  584 |                 lockf(fd, F_ULOCK, 0);
      |                 ^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:596:13: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  596 |             lockf(fd, F_ULOCK, 0);
      |             ^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:601:13: warning: ignoring return value of ‘lockf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  601 |             lockf(fd, F_ULOCK, 0);
      |             ^~~~~~~~~~~~~~~~~~~~~
make[3]: *** [../Makedefs:32: jsvc-unix.o] Error 1
make[3]: Leaving directory '/build/reproducible-path/commons-daemon-1.0.15/src/native/unix/native'
make[2]: *** [Makefile:26: native/all] Error 2
make[2]: Leaving directory '/build/reproducible-path/commons-daemon-1.0.15/src/native/unix'
dh_auto_build: error: cd src/native/unix && make -j8 returned exit code 2
make[1]: *** [debian/rules:27: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/commons-daemon-1.0.15'
make: *** [debian/rules:19: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2