Bug#1102062: zookeeper: FTBFS: expected: <1> but was: <0>

[tony mancill]

On Fri, Jul 04, 2025 at 09:21:19PM +0200, Santiago Vila wrote:
> On Fri, Jul 04, 2025 at 06:12:34PM +0000, tony mancill wrote:
> 
> > Because the failures occur for multiple different tests, I don't think
> > we should attempt to disable tests 1-by-1, I expect that to become a
> > game of whack-a-mole.  As you suggested, we should engage with upstream
> > regarding the Heisentests.  I will work on that.
> 
> Thanks a lot!
> 
> > For the trixie release, we can either request that the bug be ignored by
> > the Release Managers or I can upload a packaging change to skip tests
> > during the build by default and then request a freeze exception.
> > 
> > If anyone has a strong preference, please speak up.
> 
> Requesting that the bug is ignored seems ok to me, as far as we can
> apply the fix in trixie after we have such fix, even if that
> happens after the release of Debian 13 (i.e. stable-proposed-updates
> where stable=trixie).

As a justification for disabling the tests by default, here are failure
counts by test for a sequence of 50 or so builds.  Approximately a 50%
build failure rate and 10 distinct failing tests (so far):

      9 [ERROR]   RequestThrottlerTest.testRequestThrottler:235 expected: <5> but was: <4>
      8 [ERROR]   SaslAuthRequiredMultiClientTest.testClientOpWithInvalidSASLPasswordAuthAfterSuccessLogin:76->ClientBase.createClient:185->ClientBase.createClient:190->ClientBase.createClient:205->ClientBase.createClient:224 expected [0x1004bb8efa30001] ==> expected: <1> but was: <0>
      5 [ERROR]   SnapshotAndRestoreCommandTest.testSnapshotAndRestoreCommand_streaming:168->validateSnapshotMetrics:398 expected: <true> but was: <false>
      3 [ERROR]   QuorumPeerMainTest.testLeaderOutOfView:884 expected: <LOOKING> but was: <FOLLOWING>
      3 [ERROR]   SessionTest.testSessionStateNoDupStateReporting:294 expected: <[SyncConnected, Disconnected, Expired]> but was: <[SyncConnected, Disconnected]>
      1 [ERROR]   WatcherCleanerTest.testDeadWatcherMetrics:168->ZKTestCase.waitForMetric:144->ZKTestCase.waitForMetric:150->ZKTestCase.waitFor:140 metric "max_dead_watchers_cleaner_latency" failed to match after 30 seconds
      1 [ERROR]   RestoreQuorumTest.testRestoreAfterQuorumLost:93 expected: <20> but was: <19>
      1 [ERROR]   ReconfigRollingRestartCompatibilityTest.testRollingRestartWithHostAddedAndRemoved:317 waiting for server 3 being up ==> expected: <true> but was: <false>
      1 [ERROR]   DIFFSyncTest.testLeaderShutdown_AckProposalBeforeAckNewLeader:191 expected: <200000001> but was: <100000003>
      1 [ERROR]   CnxManagerTest.testWorkerThreads:511 Mon Jul 07 06:25:51 UTC 2025 Incorrect number of Worker threads for sid=0 expected 4 found 2 ==> expected: <null> but was: <Mon Jul 07 06:25:51 UTC 2025 Incorrect number of Worker threads for sid=0 expected 4 found 2>


So, I have prepared an upload for unstable that skips running the test
suite by default but permits the builder to enable it by setting an
environment variable. Kind of the opposite of DEB_BUILD_OPTIONS=nocheck,
although I used a different, non-standard variable to avoid confusion.

Any concerns with an upload now?  I see that Paul has already tagged the
bug with trixie-ignore.  I am not expecting this to migrate before the
release (unless the Release Managers feel otherwise).

I will continue to work on addressing the root cause.

Thank you,
tony