Bug#1136585: service-wrapper-java uses pidof but does not depend on procps

[Gioele Barabucci]

Source: service-wrapper-java
Version: 3.5.51-2
Usertags: pidof-without-procps

Dear maintainer(s) of service-wrapper-java,

it appears that service-wrapper-java uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of service-wrapper-java
  that use `pidof` at runtime;
* via the `Build-Depends:` field of service-wrapper-java, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of service-wrapper-java, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that service-wrapper-java uses `pidof` due to the following
code snippets:

```
path: service-wrapper-java_3.5.51-2/src/bin/App.sh.in
    fi
    resolveLocation PIDOF_BIN pidof ";/bin;/usr/sbin" 1
    result=`$PIDOF_BIN systemd`
    return $?
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci