libcentres-java_1.4-1_amd64.changes REJECTED

[Andrius Merkys]

Hello,

Thanks for the thorough review.

On 10/12/26 13:00, Andrew McMillan wrote:
> Several of these issues might be incorrect: please advise if they are wrong so I can ignore them on a future upload. In particular I did not attempt to build the package, so the assertions about FTBFS on current buildds may be incorrect however the licensing issues #3 and #4 below need fixing before I can accept.
> 
> 
> 1. [packaging] Build fails: pom pins javac source/target 1.7, but default-jdk is OpenJDK 25

[skip]

Build does not fail, but it complains about obsolete source/target 
options. I bumped them to 9 in debian/maven.properties, as you have 
suggested.

> 2. [packaging] cdk module's shade plugin builds an uberjar that embeds the whole CDK

[skip]

CDK's classes were not added to libcentres-java JARs, but just to have a 
cleanroom approach I now ignore maven-shade-plugin.
> 3. [licensing] BSD-2-clause License stanza in debian/copyright is truncated

[skip]

Good catch, I have added the missing part of the stanza.

> 4. [licensing] Root pom.xml declares LGPL-3.0 while actual license is BSD-2

[skip]

I forwarded the issue upstream [1] where it was quickly fixed. I 
backported the fix to the package via patch.

[1] https://github.com/SiMolecule/centres/issues/18

> 5. [packaging] Outdated Standards-Version (4.7.0, current is 4.7.4.1)
Fixed. I will upload -2 shortly.

Best wishes,
Andrius