[Pkg-javascript-commits] [dojo] 28/32: Fixes #16833. Use removeNode on IE to avoid leaks when event handlers are on the node and removeChild everywhere else. Backport thru 1.6. !strict

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag 1.6.2
in repository dojo.

commit 533bc55963b7a4e407ac9875e2e9786d0579973c
Author: Douglas Hays <doughays at dojotoolkit.org>
Date:   Wed Mar 27 22:19:40 2013 +0000

    Fixes #16833.  Use removeNode on IE to avoid leaks when event handlers are on the node and removeChild everywhere else.  Backport thru 1.6. !strict
    
    git-svn-id: http://svn.dojotoolkit.org/src/branches/1.6/dojo@31027 560b804f-0ae3-0310-86f3-f6aa0a117693
---
 _base/html.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/_base/html.js b/_base/html.js
index 328ce62..eacd7bb 100644
--- a/_base/html.js
+++ b/_base/html.js
@@ -103,7 +103,11 @@ if(dojo.isIE){
 			_empty(node);
 		}
 		if(parent){
-			parent.removeChild(node);
+//>>excludeStart("webkitMobile", kwArgs.webkitMobile);
+			// removeNode(false) doesn't leak in IE 6+, but removeChild() and removeNode(true) are known to leak under IE 8- while 9+ is TBD
+			d.isIE ? node.removeNode(false) :
+//>>excludeEnd("webkitMobile");
+				parent.removeChild(node);
 		}
 	}
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git