[Pkg-javascript-commits] [dojo] 49/87: IE9+ do not have bugs in offsets, so stop trying to "fix" them. This is why browser sniffs are bad. Refs #12342. Backport to 1.7.

David Prévot taffit at moszumanska.debian.org
Thu Aug 21 17:39:20 UTC 2014


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag 1.7.5
in repository dojo.

commit 084e8524d1a16d670127447cc860909aa98e6e7a
Author: Colin Snover <github.com at zetafleet.com>
Date:   Fri Nov 23 03:03:41 2012 +0000

    IE9+ do not have bugs in offsets, so stop trying to "fix" them. This is why browser sniffs are bad. Refs #12342.
    Backport to 1.7.
    
    
    git-svn-id: http://svn.dojotoolkit.org/src/branches/1.7/dojo@30007 560b804f-0ae3-0310-86f3-f6aa0a117693
---
 dom-geometry.js              | 2 +-
 tests/_base/html_quirks.html | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dom-geometry.js b/dom-geometry.js
index f553ec0..a920ade 100644
--- a/dom-geometry.js
+++ b/dom-geometry.js
@@ -693,7 +693,7 @@ define(["./_base/sniff", "./_base/window","./dom", "./dom-style"],
 			ret = node.getBoundingClientRect();
 		ret = {x: ret.left, y: ret.top, w: ret.right - ret.left, h: ret.bottom - ret.top};
 		//>>excludeStart("webkitMobile", kwArgs.webkitMobile);
-		if(has("ie")){
+		if(has("ie") && has("ie") < 9){
 			// On IE there's a 2px offset that we need to adjust for, see dojo.getIeDocumentElementOffset()
 			var offset = geom.getIeDocumentElementOffset();
 
diff --git a/tests/_base/html_quirks.html b/tests/_base/html_quirks.html
index 097cf98..cce0fef 100644
--- a/tests/_base/html_quirks.html
+++ b/tests/_base/html_quirks.html
@@ -66,7 +66,7 @@
 						}
 					]
 				);
-				if(dojo.isIE){ 
+				if(dojo.isIE && dojo.isIE < 9){ 
 					// IE collapses padding in quirks mode. We just report on it.
 					doh.register("t", 
 						[

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git



More information about the Pkg-javascript-commits mailing list