[Pkg-javascript-commits] [dojo] 86/87: Remove incorrect method call. Fixes #17048. !strict due to strict mode Backport to 1.7

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag 1.7.5
in repository dojo.

commit 4b3bfd5ffb999435fadb7c75dd8b1447a22867af
Author: Colin Snover <github.com at zetafleet.com>
Date:   Fri Apr 19 23:14:45 2013 +0000

    Remove incorrect method call. Fixes #17048. !strict due to strict mode
    Backport to 1.7
    
    
    git-svn-id: http://svn.dojotoolkit.org/src/branches/1.7/dojo@31310 560b804f-0ae3-0310-86f3-f6aa0a117693
---
 aspect.js       |  1 -
 tests/aspect.js | 29 +++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/aspect.js b/aspect.js
index bef673a..361b683 100644
--- a/aspect.js
+++ b/aspect.js
@@ -107,7 +107,6 @@ define([], function(){
 			signal = {
 				remove: function(){
 					if(advised){
-						advised.remove();
 						advised = dispatcher = advice = null;
 					}
 				},
diff --git a/tests/aspect.js b/tests/aspect.js
index 06c6d43..27ee38a 100644
--- a/tests/aspect.js
+++ b/tests/aspect.js
@@ -94,6 +94,35 @@ doh.register("tests.aspect",
 			obj.method(4);
 			t.is(order, [0,1,2,3,4,5,6]);
 		},
+		function around2(t){
+			var order = [];
+			var obj = {
+				method: function(a){
+					order.push(1);
+				}
+			};
+			var signal1 = aspect.around(obj, "method", function(original){
+				return function(a){
+					original();
+					order.push(2);
+				};
+			});
+			var signal2 = aspect.around(obj, "method", function(original){
+				return function(a){
+					original();
+					order.push(3);
+				};
+			});
+			var signal3 = aspect.around(obj, "method", function(original){
+				return function(a){
+					original();
+					order.push(4);
+				};
+			});
+			signal2.remove();
+			obj.method();
+			t.is(order, [1,2,4]);
+		},
 		function multipleRemove(t){
 			var foo = {bar: function(){}};
 			var order = [];

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git