[Pkg-javascript-commits] [dojo] 05/88: backport [29745] and [29746] to 1.8 branch, fixes #15838 on 1.8/ branch !strict.

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag 1.8.5
in repository dojo.

commit 31bb6a298034fc7370d3905dad3d5bc7cd24cf44
Author: Bill Keese <bill at dojotoolkit.org>
Date:   Tue Aug 14 01:40:33 2012 +0000

    backport [29745] and [29746] to 1.8 branch, fixes #15838 on 1.8/ branch !strict.
    
    git-svn-id: http://svn.dojotoolkit.org/src/branches/1.8/dojo@29482 560b804f-0ae3-0310-86f3-f6aa0a117693
---
 dnd/Selector.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dnd/Selector.js b/dnd/Selector.js
index 188ddfc..747150f 100644
--- a/dnd/Selector.js
+++ b/dnd/Selector.js
@@ -193,6 +193,10 @@ var Selector = declare("dojo.dnd.Selector", Container, {
 			if(mouse.isLeft(e)){
 				// accept the left button and stop the event
 				// for IE we don't stop event when multiple buttons are pressed
+				// TODO: remove this if() completely for 2.0, because event.stop() is useless and dangerous:
+				// on mobile, it prevents a click event, and also prevents scroll (see #15838).   Of course,
+				// drag-scroll should be disabled while dragging, and that is handled by Source::onMouseMove(),
+				// but Selector.js itself shouldn't interfere with scroll.
 				event.stop(e);
 			}
 			return;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git