[Pkg-javascript-commits] [dojo] 80/88: Fix error with .orphan() in request/iframe (1.8 backport). refs #15383 !strict

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag 1.8.5
in repository dojo.

commit 43be0e1fd3712191d817c13f2091010a465e0966
Author: Bryan Forbes <bryan at reigndropsfall.net>
Date:   Thu Apr 18 15:03:23 2013 +0000

    Fix error with .orphan() in request/iframe (1.8 backport). refs #15383 !strict
    
    git-svn-id: http://svn.dojotoolkit.org/src/branches/1.8/dojo@31294 560b804f-0ae3-0310-86f3-f6aa0a117693
---
 request/iframe.js         | 7 ++++---
 tests/request/iframe.html | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/request/iframe.js b/request/iframe.js
index 5415d88..a7576ac 100644
--- a/request/iframe.js
+++ b/request/iframe.js
@@ -10,10 +10,11 @@ define([
 	'../has',
 	'../dom',
 	'../dom-construct',
-	'../_base/window'/*=====,
+	'../_base/window',
+	'../NodeList-dom'/*=====,
 	'../request',
 	'../_base/declare' =====*/
-], function(module, require, watch, util, handlers, lang, ioQuery, query, has, dom, domConstruct, win/*=====, request, declare =====*/){
+], function(module, require, watch, util, handlers, lang, ioQuery, query, has, dom, domConstruct, win/*=====, NodeList, request, declare =====*/){
 	var mid = module.id.replace(/[\/\.\-]/g, '_'),
 		onload = mid + '_onload';
 
@@ -247,7 +248,7 @@ define([
 						if(methodNode){
 							methodNode.value = options.method;
 						}else{
-							formNode.setAttribute("method", options.method);
+							formNode.setAttribute('method', options.method);
 						}
 					}
 				}
diff --git a/tests/request/iframe.html b/tests/request/iframe.html
index b01f6c7..b23cc61 100644
--- a/tests/request/iframe.html
+++ b/tests/request/iframe.html
@@ -13,7 +13,7 @@
 		</script>
 		<script type="text/javascript" src="../../dojo.js"></script>
 		<script type="text/javascript">
-			require(["doh", "dojo/request/iframe", "dojo/dom", "dojo/domReady!"], function(doh, iframe, dom){
+			require(["doh", "dojo/request/iframe", "dojo/_base/lang", "dojo/dom", "dojo/domReady!"], function(doh, iframe, lang, dom){
 				doh.register("dojo/request/iframe", [
 					function ioIframeGetText(t){
 						var d = new doh.Deferred();
@@ -131,7 +131,7 @@
 						});
 						td.then(d.getTestCallback(function(data){
 							t.is(4, data.documentElement.getElementsByTagName("child").length);
-						}));
+						}), lang.hitch(d, "errback"));
 						return d;
 					},
 					function ioIframeDataArray(t){

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git