[Pkg-javascript-commits] [sockjs-client] 375/434: Fix #57 - Opera adds iframe navigation to history

Tonnerre Lombard tonnerre-guest at moszumanska.debian.org
Wed Jan 8 00:47:26 UTC 2014


This is an automated email from the git hooks/post-receive script.

tonnerre-guest pushed a commit to branch master
in repository sockjs-client.

commit 6ea8409b82c0a125423c16fabb291bfb587f2f99
Author: Marek Majkowski <majek04 at gmail.com>
Date:   Tue Mar 27 15:33:01 2012 +0100

    Fix #57 - Opera adds iframe navigation to history
    
    So we shouldn't use "about:blank" addresses during iframe cleanup. Semantically, empty string "" should be exactly the same as "about:blank", so we can just use that.
---
 lib/dom.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/dom.js b/lib/dom.js
index 789a42d..e7eca25 100644
--- a/lib/dom.js
+++ b/lib/dom.js
@@ -96,7 +96,7 @@ utils.createIframe = function (iframe_url, error_callback) {
             // This is required, in order to force ie7 to fire the
             // onunload event. Setting .src must happen before the
             // removeChild step.
-            iframe.src = "about:blank";
+            iframe.src = "";
             // This timeout makes chrome fire onbeforeunload event
             // within iframe. Without the timeout it goes straight to
             // onunload.
@@ -157,7 +157,7 @@ utils.createHtmlfile = function (iframe_url, error_callback) {
             unattach();
             utils.detachEvent('unload', cleanup);
             try {
-                iframe.src = "about:blank";
+                iframe.src = "";
             } catch (x) {}
             iframe.parentNode.removeChild(iframe);
             iframe = doc = null;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/sockjs-client.git



More information about the Pkg-javascript-commits mailing list