[Pkg-javascript-commits] [pdf.js] 118/204: Improve the getData unit test

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository pdf.js.

commit dc5b0d251f1b5082b46ffa253ad3195701836b28
Author: Jonas Jenwald <jonas.jenwald at gmail.com>
Date:   Tue Sep 23 13:16:58 2014 +0200

    Improve the getData unit test
    
    As a follow-up to PR #4795, this patch improves the `getData` unit test to ensure that the returned data is of the expected type and of the correct length.
---
 test/unit/api_spec.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/test/unit/api_spec.js b/test/unit/api_spec.js
index c6bf660..a8ba838 100644
--- a/test/unit/api_spec.js
+++ b/test/unit/api_spec.js
@@ -8,6 +8,7 @@
 describe('api', function() {
   // TODO run with worker enabled
   var basicApiUrl = combineUrl(window.location.href, '../pdfs/basicapi.pdf');
+  var basicApiFileLength = 105779; // bytes
   function waitsForPromiseResolved(promise, successCallback) {
     var data;
     promise.then(function(val) {
@@ -72,7 +73,7 @@ describe('api', function() {
           typedArrayPdf = new Uint8Array(request.response);
         }
         // Sanity check to make sure that we fetched the entire PDF file.
-        expect(typedArrayPdf.length).toEqual(105779);
+        expect(typedArrayPdf.length).toEqual(basicApiFileLength);
 
         var promise = PDFJS.getDocument(typedArrayPdf);
         waitsForPromiseResolved(promise, function(data) {
@@ -155,13 +156,14 @@ describe('api', function() {
     it('gets data', function() {
       var promise = doc.getData();
       waitsForPromiseResolved(promise, function (data) {
-        expect(true).toEqual(true);
+        expect(data instanceof Uint8Array).toEqual(true);
+        expect(data.length).toEqual(basicApiFileLength);
       });
     });
     it('gets filesize in bytes', function() {
       var promise = doc.getDownloadInfo();
       waitsForPromiseResolved(promise, function (data) {
-        expect(data.length).toEqual(105779);
+        expect(data.length).toEqual(basicApiFileLength);
       });
     });
     it('gets stats', function() {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/pdf.js.git