[Pkg-javascript-commits] [pdf.js] 192/246: Fix CMap unit tests

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository pdf.js.

commit 1fb404aff2ee61e04b8b74f489154be21086ad06
Author: Jonas Jenwald <jonas.jenwald at gmail.com>
Date:   Thu Aug 14 01:31:18 2014 +0200

    Fix CMap unit tests
    
    When the binary CMaps were added, some of the relevant unit tests were not changed. This patch updates them, so that we actually test the current implementation.
    What's somewhat troubling here is that we currently have CMap unit tests that passes, *despite* not working as intended (the CMap files doesn't load).
---
 test/unit/cmap_spec.js | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/test/unit/cmap_spec.js b/test/unit/cmap_spec.js
index e3c2a0b..e7ad60a 100644
--- a/test/unit/cmap_spec.js
+++ b/test/unit/cmap_spec.js
@@ -4,6 +4,9 @@
 
 'use strict';
 
+var cMapUrl = '../../external/bcmaps/';
+var cMapPacked = true;
+
 describe('cmap', function() {
   it('parses beginbfchar', function() {
     var str = '2 beginbfchar\n' +
@@ -87,8 +90,10 @@ describe('cmap', function() {
   it('read usecmap', function() {
     var str = '/Adobe-Japan1-1 usecmap\n';
     var stream = new StringStream(str);
-    var cmap = CMapFactory.create(stream, null, '../../external/cmaps/');
-    expect(cmap.useCMap).toBeDefined();
+    var cmap = CMapFactory.create(stream,
+                                  { url: cMapUrl, packed: cMapPacked }, null);
+    expect(cmap.useCMap).not.toBeNull();
+    expect(cmap.builtInCMap).toBeUndefined();
   });
   it('parses wmode', function() {
     var str = '/WMode 1 def\n';
@@ -97,8 +102,10 @@ describe('cmap', function() {
     expect(cmap.vertical).toEqual(true);
   });
   it('loads built in cmap', function() {
-    CMapFactory.create(new Name('Adobe-Japan1-1'), '../../external/cmaps/',
-                       null);
+    var cmap = CMapFactory.create(new Name('Adobe-Japan1-1'),
+                                  { url: cMapUrl, packed: cMapPacked }, null);
+    expect(cmap.useCMap).toBeNull();
+    expect(cmap.builtInCMap).toBeTruthy();
   });
 });
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/pdf.js.git