[Pkg-javascript-commits] [pdf.js] 61/157: Add a unit-test that attempts to fetch a non-existent named destination

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository pdf.js.

commit 940bedf75ff7cb5cfe057493bb4d33c453b92ffa
Author: Jonas Jenwald <jonas.jenwald at gmail.com>
Date:   Tue Jul 7 21:48:57 2015 +0200

    Add a unit-test that attempts to fetch a non-existent named destination
    
    Doing this helped uncover an issue with the `getDestination` implementation.
    Currently if a named destination doesn't exist, the method (in `obj.js`) may return `undefined` which leads to the promise being stuck in a pending state.
    *Note:* returning `null` for this case is consistent with other methods, e.g. `getOutline` and `getAttachments`.
---
 src/core/obj.js       | 2 +-
 test/unit/api_spec.js | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/core/obj.js b/src/core/obj.js
index 7e31929..bcb9c90 100644
--- a/src/core/obj.js
+++ b/src/core/obj.js
@@ -485,7 +485,7 @@ var Catalog = (function CatalogClosure() {
       }
 
       var xref = this.xref;
-      var dest, nameTreeRef, nameDictionaryRef;
+      var dest = null, nameTreeRef, nameDictionaryRef;
       var obj = this.catDict.get('Names');
       if (obj && obj.has('Dests')) {
         nameTreeRef = obj.getRaw('Dests');
diff --git a/test/unit/api_spec.js b/test/unit/api_spec.js
index 5064e3f..895039b 100644
--- a/test/unit/api_spec.js
+++ b/test/unit/api_spec.js
@@ -129,6 +129,12 @@ describe('api', function() {
                               0, 841.89, null]);
       });
     });
+    it('gets a non-existent destination', function() {
+      var promise = doc.getDestination('non-existent-named-destination');
+      waitsForPromiseResolved(promise, function(data) {
+        expect(data).toEqual(null);
+      });
+    });
     it('gets attachments', function() {
       var promise = doc.getAttachments();
       waitsForPromiseResolved(promise, function (data) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/pdf.js.git