[Pkg-javascript-commits] [backbone] 99/173: Add ESLint rule: block-scoped-var

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to branch master
in repository backbone.

commit cc3419e27198b61b6983dd5dd05517a276c43b95
Author: Jordan Eldredge <jordan at jordaneldredge.com>
Date:   Mon Dec 28 20:55:20 2015 -0800

    Add ESLint rule: block-scoped-var
    
    We're already pretty good about this rule, except there were two places where
    we defined an `i` counter, and then reused it in a different loop.
---
 .eslintrc   | 1 +
 backbone.js | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index b470e82..ad16a76 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -10,6 +10,7 @@
   },
   "rules": {
     "array-bracket-spacing": [2],
+    "block-scoped-var": 2,
     "brace-style": [1, "1tbs", {"allowSingleLine": true}],
     "camelcase": 2,
     "comma-dangle": [2, "never"],
diff --git a/backbone.js b/backbone.js
index caf45ca..335da86 100644
--- a/backbone.js
+++ b/backbone.js
@@ -769,7 +769,8 @@
     at = Math.min(Math.max(at, 0), array.length);
     var tail = Array(array.length - at);
     var length = insert.length;
-    for (var i = 0; i < tail.length; i++) tail[i] = array[i + at];
+    var i;
+    for (i = 0; i < tail.length; i++) tail[i] = array[i + at];
     for (i = 0; i < length; i++) array[i + at] = insert[i];
     for (i = 0; i < tail.length; i++) array[i + length + at] = tail[i];
   };
@@ -845,8 +846,8 @@
 
       // Turn bare objects into model references, and prevent invalid models
       // from being added.
-      var model;
-      for (var i = 0; i < models.length; i++) {
+      var model, i;
+      for (i = 0; i < models.length; i++) {
         model = models[i];
 
         // If a duplicate is found, prevent it from being added and

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/backbone.git