[Pkg-javascript-commits] [ltx] 395/469: do not expose DOMElement

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to branch master
in repository ltx.

commit fa74600dd745a666ce78b478071bc0fae3e0f22b
Author: Sonny Piers <sonny at fastmail.net>
Date:   Thu Sep 10 04:03:43 2015 +0200

    do not expose DOMElement
---
 lib/DOMElement.js        |  4 ++--
 lib/index.js             |  8 ++------
 test/dom-element-test.js | 11 ++++++-----
 3 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/lib/DOMElement.js b/lib/DOMElement.js
index 099bb1f..b8a57e3 100644
--- a/lib/DOMElement.js
+++ b/lib/DOMElement.js
@@ -1,6 +1,6 @@
 'use strict';
 
-var util = require('util')
+var inherits = require('inherits')
   , Element = require('./Element')
 
 function DOMElement(name, attrs) {
@@ -10,7 +10,7 @@ function DOMElement(name, attrs) {
     this.nodeName = this.localName
 }
 
-util.inherits(DOMElement, Element)
+inherits(DOMElement, Element)
 
 DOMElement.prototype._getElement = function(name, attrs) {
     var element = new DOMElement(name, attrs)
diff --git a/lib/index.js b/lib/index.js
index 4134cdb..2f82b99 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -4,19 +4,15 @@ var parse = require('./parse')
 var Parser = require('./Parser')
 var escape = require('./escape')
 var Element = require('./Element')
-var DOMElement = require('./DOMElement')
 
 /**
- * The only (relevant) data structure
+ * Element
  */
 exports.Element = Element
 exports.createElement = Element.createElement
 
-exports.DOMElement = DOMElement
-exports.createDOMElement = DOMElement.createElement
-
 /**
- * Helper
+ * Helpers
  */
 exports.escapeXML = escape.escapeXML
 exports.escapeXMLText = escape.escapeXMLText
diff --git a/test/dom-element-test.js b/test/dom-element-test.js
index 6ef4202..c6c3324 100644
--- a/test/dom-element-test.js
+++ b/test/dom-element-test.js
@@ -4,10 +4,11 @@ var vows = require('vows')
   , assert = require('assert')
   , ltx = require('../lib/index')
   , parsers = require('../lib/parsers')
+  , DOMElement = require('../lib/DOMElement')
 
 parsers.forEach(function(Parser) {
     var parse = function(s) {
-        return ltx.parse(s, {Parser: Parser, Element: ltx.DOMElement})
+        return ltx.parse(s, {Parser: Parser, Element: DOMElement})
     }
     vows.describe('Parsing returns DOMElement\'s').addBatch({
         'DOMElement': {
@@ -16,7 +17,7 @@ parsers.forEach(function(Parser) {
                     '<p>DOM</p></body></message>'
                 var el = parse(stanza)
 
-                assert(el.getChild('body') instanceof ltx.DOMElement)
+                assert(el.getChild('body') instanceof DOMElement)
                 assert.equal(el.getChild('body').constructor.name, 'DOMElement')
                 var body = el.getChild('body')
                 assert.isDefined(body.localName)
@@ -40,9 +41,9 @@ parsers.forEach(function(Parser) {
         },
         'createElement': {
             'create a new element and set children': function() {
-                var c = new ltx.DOMElement('bar')
-                var e = ltx.createDOMElement('foo', {'foo': 'bar'}, 'foo', c)
-                assert(e instanceof ltx.DOMElement)
+                var c = new DOMElement('bar')
+                var e = DOMElement.createElement('foo', {'foo': 'bar'}, 'foo', c)
+                assert(e instanceof DOMElement)
                 assert.equal(e.localName, 'foo')
                 assert.equal(e.getAttribute('foo'), 'bar')
                 assert.equal(e.childNodes.length, 2)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/ltx.git