[Pkg-javascript-commits] [uglifyjs] 25/228: fix duplicated test names

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to branch master
in repository uglifyjs.

commit c525a2b1907fdef36acffdeea4cf02ae476d8399
Author: alexlamsl <alexlamsl at gmail.com>
Date:   Sat Feb 18 19:15:09 2017 +0800

    fix duplicated test names
    
    previously test cases with the same name would be skipped except for the last one
    
    `test/run-test.js` will now report duplicated names as errors
    
    closes #1461
---
 test/compress/drop-console.js |  2 +-
 test/compress/hoist_vars.js   | 90 +++++++++++++++++++++++++++++++++++++++++++
 test/compress/negate-iife.js  |  6 +--
 test/run-tests.js             |  3 ++
 4 files changed, 97 insertions(+), 4 deletions(-)

diff --git a/test/compress/drop-console.js b/test/compress/drop-console.js
index 162b339..2333722 100644
--- a/test/compress/drop-console.js
+++ b/test/compress/drop-console.js
@@ -10,7 +10,7 @@ drop_console_1: {
     }
 }
 
-drop_console_1: {
+drop_console_2: {
     options = { drop_console: true };
     input: {
         console.log('foo');
diff --git a/test/compress/hoist_vars.js b/test/compress/hoist_vars.js
new file mode 100644
index 0000000..6fe1c77
--- /dev/null
+++ b/test/compress/hoist_vars.js
@@ -0,0 +1,90 @@
+statements: {
+    options = {
+        hoist_funs: false,
+        hoist_vars: true,
+    }
+    input: {
+        function f() {
+            var a = 1;
+            var b = 2;
+            var c = 3;
+            function g() {}
+            return g(a, b, c);
+        }
+    }
+    expect: {
+        function f() {
+            var a = 1, b = 2, c = 3;
+            function g() {}
+            return g(a, b, c);
+        }
+    }
+}
+
+statements_funs: {
+    options = {
+        hoist_funs: true,
+        hoist_vars: true,
+    }
+    input: {
+        function f() {
+            var a = 1;
+            var b = 2;
+            var c = 3;
+            function g() {}
+            return g(a, b, c);
+        }
+    }
+    expect: {
+        function f() {
+            function g() {}
+            var a = 1, b = 2, c = 3;
+            return g(a, b, c);
+        }
+    }
+}
+
+sequences: {
+    options = {
+        hoist_funs: false,
+        hoist_vars: true,
+    }
+    input: {
+        function f() {
+            var a = 1, b = 2;
+            function g() {}
+            var c = 3;
+            return g(a, b, c);
+        }
+    }
+    expect: {
+        function f() {
+            var c, a = 1, b = 2;
+            function g() {}
+            c = 3;
+            return g(a, b, c);
+        }
+    }
+}
+
+sequences_funs: {
+    options = {
+        hoist_funs: true,
+        hoist_vars: true,
+    }
+    input: {
+        function f() {
+            var a = 1, b = 2;
+            function g() {}
+            var c = 3;
+            return g(a, b, c);
+        }
+    }
+    expect: {
+        function f() {
+            function g() {}
+            var a = 1, b = 2, c = 3;
+            return g(a, b, c);
+        }
+    }
+}
diff --git a/test/compress/negate-iife.js b/test/compress/negate-iife.js
index 312e0f2..001795c 100644
--- a/test/compress/negate-iife.js
+++ b/test/compress/negate-iife.js
@@ -58,7 +58,7 @@ negate_iife_3_off: {
     }
 }
 
-negate_iife_3: {
+negate_iife_4: {
     options = {
         negate_iife: true,
         conditionals: true,
@@ -112,7 +112,7 @@ sequence_off: {
     }
 }
 
-negate_iife_4: {
+negate_iife_5: {
     options = {
         negate_iife: true,
         sequences: true,
@@ -135,7 +135,7 @@ negate_iife_4: {
     }
 }
 
-negate_iife_4_off: {
+negate_iife_5_off: {
     options = {
         negate_iife: false,
         sequences: true,
diff --git a/test/run-tests.js b/test/run-tests.js
index a472139..15a12c6 100755
--- a/test/run-tests.js
+++ b/test/run-tests.js
@@ -194,6 +194,9 @@ function parse_test(file) {
         if (node instanceof U.AST_LabeledStatement
             && tw.parent() instanceof U.AST_Toplevel) {
             var name = node.label.name;
+            if (name in tests) {
+                throw new Error('Duplicated test name "' + name + '" in ' + file);
+            }
             tests[name] = get_one_test(name, node.body);
             return true;
         }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/uglifyjs.git