[Pkg-javascript-commits] [node-asn1.js] 91/202: node: fix strict mode error in Node.prototype.keys

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch master
in repository node-asn1.js.

commit c75d861e705df9559bf572e682552278b98a218d
Author: Karl Cheng <qantas94heavy at gmail.com>
Date:   Tue Jan 27 21:21:45 2015 +0800

    node: fix strict mode error in Node.prototype.keys
    
    Having an argument with the same name as a named function expression
    is a syntax error in strict mode, which can cause errors when combined
    with other files using strict mode.
    
    See http://stackoverflow.com/q/28170788 for an example of this bug.
---
 lib/asn1/base/node.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/asn1/base/node.js b/lib/asn1/base/node.js
index 508ebc9..9c03beb 100644
--- a/lib/asn1/base/node.js
+++ b/lib/asn1/base/node.js
@@ -222,11 +222,11 @@ Node.prototype.obj = function obj() {
   return this;
 };
 
-Node.prototype.key = function key(key) {
+Node.prototype.key = function key(newKey) {
   var state = this._baseState;
 
   assert(state.key === null);
-  state.key = key;
+  state.key = newKey;
 
   return this;
 };

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/node-asn1.js.git