[Pkg-javascript-commits] [node-browserify-zlib] 05/50: Set up test in karma

Bastien Roucariès rouca at moszumanska.debian.org
Fri Dec 15 13:09:39 UTC 2017


This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch master
in repository node-browserify-zlib.

commit aba80146acfd8679b3f05f953c7e5d06131857b0
Author: dignifiedquire <dignifiedquire at gmail.com>
Date:   Thu Mar 31 16:24:07 2016 -0400

    Set up test in karma
---
 .travis.yml                                       |  4 ++
 karma.conf.js                                     | 14 +++++++
 npm-debug.log                                     | 48 +++++++++++++++++++++++
 package.json                                      | 14 ++++++-
 src/index.js                                      | 20 ++++++++--
 test/package.json                                 |  7 ----
 test/test-zlib-dictionary.js                      | 22 +++++------
 test/test-zlib-from-concatenated-gzip.js          |  8 ++--
 test/test-zlib-from-gzip-with-trailing-garbage.js |  8 ++--
 test/test-zlib-from-gzip.js                       | 25 ++++++------
 test/test-zlib-invalid-input.js                   |  4 +-
 test/test-zlib-params.js                          | 18 ++++-----
 test/test-zlib-truncated.js                       | 10 ++---
 test/test-zlib.js                                 | 14 ++-----
 14 files changed, 147 insertions(+), 69 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 96be99c..d23672e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,6 +4,10 @@ node_js:
   - '5'
   - stable
 
+before_install:
+  - "export DISPLAY=:99.0"
+  - "sh -e /etc/init.d/xvfb start"
+
 script:
   - npm run lint
   - npm test
diff --git a/karma.conf.js b/karma.conf.js
new file mode 100644
index 0000000..5e8f992
--- /dev/null
+++ b/karma.conf.js
@@ -0,0 +1,14 @@
+module.exports = function (karma) {
+  karma.set({
+    frameworks: ['browserify', 'mocha'],
+    files: ['test/**/test-*.js'],
+    preprocessors: {
+      'test/**/test-*.js': ['browserify']
+    },
+    browserify: {
+      debug: true,
+      transform: ['brfs']
+    },
+    browsers: process.env.TRAVIS ? ['Firefox', 'PhantomJS'] : ['Chrome'/*, 'PhantomJS'*/]
+  })
+}
diff --git a/npm-debug.log b/npm-debug.log
new file mode 100644
index 0000000..81556e8
--- /dev/null
+++ b/npm-debug.log
@@ -0,0 +1,48 @@
+0 info it worked if it ends with ok
+1 verbose cli [ '/Users/dignifiedquire/.nvm/versions/node/v5.7.0/bin/node',
+1 verbose cli   '/Users/dignifiedquire/.nvm/versions/node/v5.7.0/bin/npm',
+1 verbose cli   'run',
+1 verbose cli   'test:browser' ]
+2 info using npm at 3.6.0
+3 info using node at v5.7.0
+4 verbose run-script [ 'pretest:browser', 'test:browser', 'posttest:browser' ]
+5 info lifecycle browserify-zlib at 0.1.4~pretest:browser: browserify-zlib at 0.1.4
+6 silly lifecycle browserify-zlib at 0.1.4~pretest:browser: no script for pretest:browser, continuing
+7 info lifecycle browserify-zlib at 0.1.4~test:browser: browserify-zlib at 0.1.4
+8 verbose lifecycle browserify-zlib at 0.1.4~test:browser: unsafe-perm in lifecycle true
+9 verbose lifecycle browserify-zlib at 0.1.4~test:browser: PATH: /Users/dignifiedquire/.nvm/versions/node/v5.7.0/lib/node_modules/npm/bin/node-gyp-bin:/Users/dignifiedquire/opensource/ipfs/browserify-zlib/node_modules/.bin:/Users/dignifiedquire/.nvm/versions/node/v5.7.0/bin:/Users/dignifiedquire/.cargo/bin:/usr/local/texlive/2014/bin/x86_64-darwin:/Users/dignifiedquire/.cabal/bin:/usr/local/sbin:/usr/local/bin:/Users/dignifiedquire/.cask/bin:/Users/dignifiedquire/.rbenv/bin:/Users/dignified [...]
+10 verbose lifecycle browserify-zlib at 0.1.4~test:browser: CWD: /Users/dignifiedquire/opensource/ipfs/browserify-zlib
+11 silly lifecycle browserify-zlib at 0.1.4~test:browser: Args: [ '-c', 'karma start --single-run=true karma.conf.js' ]
+12 silly lifecycle browserify-zlib at 0.1.4~test:browser: Returned: code: 1  signal: null
+13 info lifecycle browserify-zlib at 0.1.4~test:browser: Failed to exec test:browser script
+14 verbose stack Error: browserify-zlib at 0.1.4 test:browser: `karma start --single-run=true karma.conf.js`
+14 verbose stack Exit status 1
+14 verbose stack     at EventEmitter.<anonymous> (/Users/dignifiedquire/.nvm/versions/node/v5.7.0/lib/node_modules/npm/lib/utils/lifecycle.js:232:16)
+14 verbose stack     at emitTwo (events.js:100:13)
+14 verbose stack     at EventEmitter.emit (events.js:185:7)
+14 verbose stack     at ChildProcess.<anonymous> (/Users/dignifiedquire/.nvm/versions/node/v5.7.0/lib/node_modules/npm/lib/utils/spawn.js:24:14)
+14 verbose stack     at emitTwo (events.js:100:13)
+14 verbose stack     at ChildProcess.emit (events.js:185:7)
+14 verbose stack     at maybeClose (internal/child_process.js:827:16)
+14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
+15 verbose pkgid browserify-zlib at 0.1.4
+16 verbose cwd /Users/dignifiedquire/opensource/ipfs/browserify-zlib
+17 error Darwin 15.4.0
+18 error argv "/Users/dignifiedquire/.nvm/versions/node/v5.7.0/bin/node" "/Users/dignifiedquire/.nvm/versions/node/v5.7.0/bin/npm" "run" "test:browser"
+19 error node v5.7.0
+20 error npm  v3.6.0
+21 error code ELIFECYCLE
+22 error browserify-zlib at 0.1.4 test:browser: `karma start --single-run=true karma.conf.js`
+22 error Exit status 1
+23 error Failed at the browserify-zlib at 0.1.4 test:browser script 'karma start --single-run=true karma.conf.js'.
+23 error Make sure you have the latest version of node.js and npm installed.
+23 error If you do, this is most likely a problem with the browserify-zlib package,
+23 error not with npm itself.
+23 error Tell the author that this fails on your system:
+23 error     karma start --single-run=true karma.conf.js
+23 error You can get information on how to open an issue for this project with:
+23 error     npm bugs browserify-zlib
+23 error Or if that isn't available, you can get their info via:
+23 error     npm owner ls browserify-zlib
+23 error There is likely additional logging output above.
+24 verbose exit [ 1, true ]
diff --git a/package.json b/package.json
index 6e9f560..2777db4 100644
--- a/package.json
+++ b/package.json
@@ -15,8 +15,16 @@
   },
   "devDependencies": {
     "brfs": "^1.0.1",
+    "karma": "^0.13.22",
+    "karma-browserify": "^5.0.3",
+    "karma-chrome-launcher": "^0.2.3",
+    "karma-firefox-launcher": "^0.1.7",
+    "karma-mocha": "^0.2.2",
+    "karma-phantomjs-launcher": "^1.0.0",
     "mocha": "^2.4.5",
-    "standard": "^6.0.8"
+    "phantomjs-prebuilt": "^2.1.7",
+    "standard": "^6.0.8",
+    "watchify": "^3.7.0"
   },
   "testling": {
     "files": "test/*.js",
@@ -33,7 +41,9 @@
   },
   "scripts": {
     "lint": "standard",
-    "test": "mocha test/test-*"
+    "test": "npm run test:node && npm run test:browser",
+    "test:browser": "karma start --single-run=true karma.conf.js",
+    "test:node": "mocha test/test-*"
   },
   "author": "Devon Govett <devongovett at gmail.com>",
   "license": "MIT",
diff --git a/src/index.js b/src/index.js
index b955971..0158652 100644
--- a/src/index.js
+++ b/src/index.js
@@ -5,9 +5,21 @@ var Transform = require('_stream_transform')
 var binding = require('./binding')
 var util = require('util')
 var assert = require('assert').ok
-var kMaxLength = require('buffer').kMaxLength
+
+function kMaxLength () {
+  var max = require('buffer').kMaxLength
+
+  if (max) {
+    return max
+  } else if (Buffer.TYPED_ARRAY_SUPPORT) {
+    return 0x7fffffff
+  } else {
+    return 0x3fffffff
+  }
+}
+
 var kRangeErrorMessage = 'Cannot create final Buffer. ' +
-  'It would be larger than 0x' + kMaxLength.toString(16) + ' bytes.'
+      'It would be larger than 0x' + kMaxLength().toString(16) + ' bytes.'
 
 // zlib doesn't provide these, so kludge them in following the same
 // var naming scheme zlib uses.
@@ -216,7 +228,7 @@ function zlibBuffer (engine, buffer, callback) {
     var buf
     var err = null
 
-    if (nread >= kMaxLength) {
+    if (nread >= kMaxLength()) {
       err = new RangeError(kRangeErrorMessage)
     } else {
       buf = Buffer.concat(buffers, nread)
@@ -540,7 +552,7 @@ Zlib.prototype._processChunk = function (chunk, flushFlag, cb) {
       throw error
     }
 
-    if (nread >= kMaxLength) {
+    if (nread >= kMaxLength()) {
       this.close()
       throw new RangeError(kRangeErrorMessage)
     }
diff --git a/test/package.json b/test/package.json
deleted file mode 100644
index 189e120..0000000
--- a/test/package.json
+++ /dev/null
@@ -1,7 +0,0 @@
-{
-  "browserify": {
-    "transform": [
-      "brfs"
-    ]
-  }
-}
\ No newline at end of file
diff --git a/test/test-zlib-dictionary.js b/test/test-zlib-dictionary.js
index 992c399..30db4f2 100644
--- a/test/test-zlib-dictionary.js
+++ b/test/test-zlib-dictionary.js
@@ -2,10 +2,10 @@
 'use strict'
 
 // test compression/decompression with dictionary
-const assert = require('assert')
-const zlib = require('../')
+var assert = require('assert')
+var zlib = require('../')
 
-const spdyDict = new Buffer([
+var spdyDict = new Buffer([
   'optionsgetheadpostputdeletetraceacceptaccept-charsetaccept-encodingaccept-',
   'languageauthorizationexpectfromhostif-modified-sinceif-matchif-none-matchi',
   'f-rangeif-unmodifiedsincemax-forwardsproxy-authorizationrangerefererteuser',
@@ -21,7 +21,7 @@ const spdyDict = new Buffer([
   '.1statusversionurl\0'
 ].join(''))
 
-const input = [
+var input = [
   'HTTP/1.1 200 Ok',
   'Server: node.js',
   'Content-Length: 0',
@@ -30,9 +30,9 @@ const input = [
 
 describe('zlib - dictionary', function () {
   it('basic dictionary', function (done) {
-    let output = ''
-    const deflate = zlib.createDeflate({ dictionary: spdyDict })
-    const inflate = zlib.createInflate({ dictionary: spdyDict })
+    var output = ''
+    var deflate = zlib.createDeflate({ dictionary: spdyDict })
+    var inflate = zlib.createInflate({ dictionary: spdyDict })
 
     deflate.on('data', function (chunk) {
       inflate.write(chunk)
@@ -56,10 +56,10 @@ describe('zlib - dictionary', function () {
   })
 
   it('deflate reset dictionary', function (done) {
-    let doneReset = false
-    let output = ''
-    const deflate = zlib.createDeflate({ dictionary: spdyDict })
-    const inflate = zlib.createInflate({ dictionary: spdyDict })
+    var doneReset = false
+    var output = ''
+    var deflate = zlib.createDeflate({ dictionary: spdyDict })
+    var inflate = zlib.createInflate({ dictionary: spdyDict })
 
     deflate.on('data', function (chunk) {
       if (doneReset) {
diff --git a/test/test-zlib-from-concatenated-gzip.js b/test/test-zlib-from-concatenated-gzip.js
index eb034a4..4969ae9 100644
--- a/test/test-zlib-from-concatenated-gzip.js
+++ b/test/test-zlib-from-concatenated-gzip.js
@@ -2,13 +2,13 @@
 'use strict'
 
 // Test unzipping a gzip file that contains multiple concatenated "members"
-const common = require('./common')
-const assert = require('assert')
-const zlib = require('../')
+var common = require('./common')
+var assert = require('assert')
+var zlib = require('../')
 
 describe.skip('zlib - from concatenated gzip', function () {
   it('works', function (done) {
-    const data = Buffer.concat([
+    var data = Buffer.concat([
       zlib.gzipSync('abc'),
       zlib.gzipSync('def')
     ])
diff --git a/test/test-zlib-from-gzip-with-trailing-garbage.js b/test/test-zlib-from-gzip-with-trailing-garbage.js
index e6c1ed5..7284773 100644
--- a/test/test-zlib-from-gzip-with-trailing-garbage.js
+++ b/test/test-zlib-from-gzip-with-trailing-garbage.js
@@ -2,13 +2,13 @@
 'use strict'
 
 // test unzipping a gzip file that has trailing garbage
-const common = require('./common')
-const assert = require('assert')
-const zlib = require('../')
+var common = require('./common')
+var assert = require('assert')
+var zlib = require('../')
 
 describe.skip('zlib - from gzip with trailing garbage', function () {
   it('should ignore trailing null-bytes', function (done) {
-    let data = Buffer.concat([
+    var data = Buffer.concat([
       zlib.gzipSync('abc'),
       zlib.gzipSync('def'),
       Buffer(10).fill(0)
diff --git a/test/test-zlib-from-gzip.js b/test/test-zlib-from-gzip.js
index e7b341f..e68021e 100644
--- a/test/test-zlib-from-gzip.js
+++ b/test/test-zlib-from-gzip.js
@@ -7,22 +7,25 @@ var common = require('./common')
 var assert = require('assert')
 var zlib = require('../')
 var path = require('path')
+var fs = require('fs')
 
-common.refreshTmpDir()
+describe('zlib - from gzip', function () {
+  it('works', function (done) {
+    if (global.window) {
+      return done()
+    }
 
-var gunzip = zlib.createGunzip()
+    common.refreshTmpDir()
 
-var fs = require('fs')
+    var gunzip = zlib.createGunzip()
 
-var fixture = path.resolve(common.fixturesDir, 'person.jpg.gz')
-var unzippedFixture = path.resolve(common.fixturesDir, 'person.jpg')
-var outputFile = path.resolve(common.tmpDir, 'person.jpg')
-var expect = fs.readFileSync(unzippedFixture)
-var inp = fs.createReadStream(fixture)
-var out = fs.createWriteStream(outputFile)
+    var fixture = path.resolve(common.fixturesDir, 'person.jpg.gz')
+    var unzippedFixture = path.resolve(common.fixturesDir, 'person.jpg')
+    var outputFile = path.resolve(common.tmpDir, 'person.jpg')
+    var expect = fs.readFileSync(unzippedFixture)
+    var inp = fs.createReadStream(fixture)
+    var out = fs.createWriteStream(outputFile)
 
-describe('zlib - from gzip', function () {
-  it('works', function (done) {
     inp.pipe(gunzip).pipe(out)
     out.on('close', function () {
       var actual = fs.readFileSync(outputFile)
diff --git a/test/test-zlib-invalid-input.js b/test/test-zlib-invalid-input.js
index 177f3a7..e1979f4 100755
--- a/test/test-zlib-invalid-input.js
+++ b/test/test-zlib-invalid-input.js
@@ -2,8 +2,8 @@
 'use strict'
 
 // test uncompressing invalid input
-const assert = require('assert')
-const zlib = require('../')
+var assert = require('assert')
+var zlib = require('../')
 
 var nonStringInputs = [1, true, {a: 1}, ['a']]
 
diff --git a/test/test-zlib-params.js b/test/test-zlib-params.js
index 534fc9e..1377da6 100644
--- a/test/test-zlib-params.js
+++ b/test/test-zlib-params.js
@@ -7,16 +7,16 @@ var zlib = require('../')
 var path = require('path')
 var fs = require('fs')
 
-const file = fs.readFileSync(path.resolve(common.fixturesDir, 'person.jpg'))
-const chunkSize = 12 * 1024
-const opts = { level: 9, strategy: zlib.Z_DEFAULT_STRATEGY }
-const deflater = zlib.createDeflate(opts)
+var file = fs.readFileSync(path.join(__dirname, 'fixtures', 'person.jpg'))
+var chunkSize = 12 * 1024
+var opts = { level: 9, strategy: zlib.Z_DEFAULT_STRATEGY }
+var deflater = zlib.createDeflate(opts)
 
-const chunk1 = file.slice(0, chunkSize)
-const chunk2 = file.slice(chunkSize)
-const blkhdr = new Buffer([0x00, 0x5a, 0x82, 0xa5, 0x7d])
-const expected = Buffer.concat([blkhdr, chunk2])
-let actual
+var chunk1 = file.slice(0, chunkSize)
+var chunk2 = file.slice(chunkSize)
+var blkhdr = new Buffer([0x00, 0x5a, 0x82, 0xa5, 0x7d])
+var expected = Buffer.concat([blkhdr, chunk2])
+var actual
 
 describe.skip('zlib - params', function () {
   it('works', function (done) {
diff --git a/test/test-zlib-truncated.js b/test/test-zlib-truncated.js
index a44a46b..2c6cd84 100644
--- a/test/test-zlib-truncated.js
+++ b/test/test-zlib-truncated.js
@@ -2,10 +2,10 @@
 'use strict'
 
 // tests zlib streams with truncated compressed input
-const assert = require('assert')
-const zlib = require('zlib')
+var assert = require('assert')
+var zlib = require('zlib')
 
-const inputString = 'ΩΩLorem ipsum dolor sit amet, consectetur adipiscing el' +
+var inputString = 'ΩΩLorem ipsum dolor sit amet, consectetur adipiscing el' +
         'it. Morbi faucibus, purus at gravida dictum, libero arcu convallis la' +
         'cus, in commodo libero metus eu nisi. Nullam commodo, neque nec porta' +
         ' placerat, nisi est fermentum augue, vitae gravida tellus sapien sit ' +
@@ -24,11 +24,11 @@ describe('zlib - truncated', function () {
     it(methods.comp, function (done) {
       zlib[methods.comp](inputString, function (err, compressed) {
         assert(!err)
-        const truncated = compressed.slice(0, compressed.length / 2)
+        var truncated = compressed.slice(0, compressed.length / 2)
 
         // sync sanity
         assert.doesNotThrow(function () {
-          const decompressed = zlib[methods.decompSync](compressed)
+          var decompressed = zlib[methods.decompSync](compressed)
           assert.equal(decompressed, inputString)
         })
 
diff --git a/test/test-zlib.js b/test/test-zlib.js
index 40ac9ed..430a17a 100644
--- a/test/test-zlib.js
+++ b/test/test-zlib.js
@@ -40,18 +40,12 @@ if (!process.env.PUMMEL) {
 
 var fs = require('fs')
 
-var testFiles = ['person.jpg', 'elipses.txt', 'empty.txt']
-
-if (process.env.FAST) {
-  zlibPairs = [[zlib.Gzip, zlib.Unzip]]
-  testFiles = ['person.jpg']
+var tests = {
+  'person.jpg': fs.readFileSync(path.join(__dirname, 'fixtures', 'person.jpg')),
+  'elipses.txt': fs.readFileSync(path.join(__dirname, 'fixtures', 'elipses.txt')),
+  // 'empty.txt': fs.readFileSync(path.join(__dirname, 'fixtures', 'empty.txt'))
 }
 
-var tests = {}
-testFiles.forEach(function (file) {
-  tests[file] = fs.readFileSync(path.resolve(common.fixturesDir, file))
-})
-
 var util = require('util')
 var stream = require('stream')
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/node-browserify-zlib.git



More information about the Pkg-javascript-commits mailing list