[Pkg-javascript-commits] [uglifyjs] 373/491: fix `pure_getters` on `AST_Binary` (#2681)

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to annotated tag debian/3.3.10-1
in repository uglifyjs.

commit b95e3338d9704927046a030fe814302f55737e0d
Author: Alex Lam S.L <alexlamsl at gmail.com>
Date:   Thu Dec 28 17:01:01 2017 +0800

    fix `pure_getters` on `AST_Binary` (#2681)
    
    fixes #2678
---
 lib/compress.js               | 11 ++---------
 test/compress/pure_getters.js | 32 ++++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 9 deletions(-)

diff --git a/lib/compress.js b/lib/compress.js
index ac5cd23..4e3a8f8 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -1693,15 +1693,8 @@ merge(Compressor.prototype, {
             return this.operator == "void";
         });
         def(AST_Binary, function(compressor) {
-            switch (this.operator) {
-              case "&&":
-                return this.left._dot_throw(compressor);
-              case "||":
-                return this.left._dot_throw(compressor)
-                    && this.right._dot_throw(compressor);
-              default:
-                return false;
-            }
+            return (this.operator == "&&" || this.operator == "||")
+                && (this.left._dot_throw(compressor) || this.right._dot_throw(compressor));
         })
         def(AST_Assign, function(compressor) {
             return this.operator == "="
diff --git a/test/compress/pure_getters.js b/test/compress/pure_getters.js
index 4174bc1..7185e0c 100644
--- a/test/compress/pure_getters.js
+++ b/test/compress/pure_getters.js
@@ -611,3 +611,35 @@ issue_2313_6: {
         x();
     }
 }
+
+issue_2678: {
+    options = {
+        pure_getters: "strict",
+        side_effects: true,
+    }
+    input: {
+        var a = 1, c = "FAIL";
+        (function f() {
+            (a-- && f()).p;
+            return {
+                get p() {
+                    c = "PASS";
+                }
+            };
+        })();
+        console.log(c);
+    }
+    expect: {
+        var a = 1, c = "FAIL";
+        (function f() {
+            (a-- && f()).p;
+            return {
+                get p() {
+                    c = "PASS";
+                }
+            };
+        })();
+        console.log(c);
+    }
+    expect_stdout: "PASS"
+}

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/uglifyjs.git