[Pkg-javascript-devel] Bug#639636: [node-dev] Re: Bug#639636: nodejs: FTBFS/armel - testsuite fails

Steven Chamberlain steven at pyro.eu.org
Sat Dec 31 01:47:18 UTC 2011


Hello,

I wonder if this commit (introduced in 0.5.10) is what fixed the failure
of test-buffer.js in later versions:

https://github.com/joyent/node/commit/6a72e525202972fe5d5a89cc94f48071380c1aa7

I have no armel build system but would appreciate if someone could
humour me by trying this :)


I came across this when I noticed there are different offsets shown for
the two buffers test-buffer.js compares:

original buffer:
> "5684":252,"5685":0,"5686":98,"5687":0,"5688":101,"5689":0,"5690":114,"5691":0,"5692":0,
> "5693":252,"5694":0,"5695":98,"5696":0,"5697":101,"5698":0,"5699":114,"5700":0,"5701":4,
> 
> "offset":5693} 

copy-constructed buffer:
> "5684":252,"5685":0,"5686":98,"5687":0,"5688":101,"5689":0,"5690":114,"5691":0,"5692":0,
> "5693":252,"5694":0,"5695":98,"5696":0,"5697":101,"5698":0,"5699":114,"5700":0,"5701":4,
> 
> "offset":5685}

So I wondered if this was due to only one byte being read or written --
stopping because of the null character -- that would leave the offset
short of where it should be, which is incidentally 1 byte into a
different copy of the string (and that is maybe what we were seeing).

Thanks,
Regards,
-- 
Steven Chamberlain
steven at pyro.eu.org





More information about the Pkg-javascript-devel mailing list