[Pkg-javascript-devel] npm packaging

[Jérémy Lal]

On 13/10/2011 14:11, Jonas Smedegaard wrote:
> On 11-10-13 at 01:08pm, Jérémy Lal wrote:
>> On 13/10/2011 12:17, Jonas Smedegaard wrote:
>>> On 11-10-13 at 11:08am, Jérémy Lal wrote:
>>>> Version 1.0.95 (in collab-maint) still needs some work (see TODO in 
>>>> changelog), but can be built and tested.
>>>
>>> Great!
>>>
>>>
>>> I will take a look at the copyright file.
>>
>> Thank you.
>>
>>> A patch 2004_man_gz.patch exist but no series file?!?
>>
>> An old one i temporarily kept. Removed.
> 
> Good.
> 
> Worse: Source contains a binary executable.  Even though the 
> accompanying notes state that the source is DFSG-free, but said sources 
> are not included and we cannot know for sure if they are in fact used. 
> Also it is statically linked which means it pulls in code from other 
> sources which is certainly not available.  Package should be repackaged 
> with deps/ subdir stripped.

Indeed, repackaging is not an option.
 
> Non-free TrueType font Gubblebum Blocky is included below html/*/.

I agree on simply removing the font file, it won't hurt.

> Also, all that documentation below html/ sems autogenerated using ronnjs.  So 
> probably html/ should be stripped and instead generated at build time 
> (with options to avoid that non-free font as needed).

Actually it's html and man pages that are generated from markdown using ronnjs.
And i'm the upstream developer of ronnjs. But i have no time left right now
to take care of packaging it. Later ?
Also, even if there generated at build time, they are not supposed to be removed
from tarball, for no DFSG reason.
 
> I notice a link to a youtube video in the regression tests.  Not sure, 
> but if any regression tests go online during build, they should be 
> disabled or patched to not do so.

I did not run the tests yet, so i don't know if it's possible to run
them during the build. I'd prefer doing that step later, too.

> Since we are mangling upstream source anyway, I suggest to also strip 
> node_modules/ to ease copyright file maintainance.  I looked briefly at 
> those embedded packages, and even if relatively small, many of them 
> contain regression tests of their own which should get proper exposure 
> by packaging them each separately.

Repackaging is supposed to be about DFSG only, no ?
So when those modules are packaged, they'll stay in the tarball, but won't
get installed.

> I postpone further copyright checking until source have been repackaged 
> (or you've convinced me it is unneeded ;-) ).

No problem.
Do you agree on excluding :
* deps/
* html/*/GubbleBum-Blocky.ttf


Then on a future version :
* regenerate html and man pages using ronnjs
* run tests offline

Jérémy.