[Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?

[Emilien Klein]

Hi Jose Luis,
2012/2/14 Jose Luis Rivas <joseluis at rivco.net>:
> On 02/12/2012 06:05 PM, Emilien Klein wrote:
>
>> Hey David and Jose Luis
>>
>> I got SSH access, created the repo on the server, and I believe I've
>> managed to create my first ever git repo properly and push it to
>> git.d.o [0]. I'm still a bit confused on the content of the different
>> branches, in particular of master:
>> jQuery's master branch only contains the debian directory, whereas my
>> master contains the entire upstream content as well...
>>
>> Anyway, please let me know what I might need to have to change.
>>
>> Good night!
>>    +Emilien
>>
>
> Hey Emilian, I just checked your package

Thanks!

> and as a first thing I do I
> build it in my cowbuilder. I got this error:
>
> 8<---
> mkdir -p debian/tmp-build
> yui-compressor jquery.lazyload.js -o debian/tmp-build/jquery.lazyload.min.js
> Error occurred during initialization of VM
> Could not reserve enough space for object heap
> Could not create the Java virtual machine.
> make[1]: *** [override_dh_auto_build] Error 1
> make[1]: Leaving directory `/tmp/buildd/jquery-lazyload-1.7.0'
> make: *** [build] Error 2
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
> E: Failed autobuilding of package
> --->8
>
> You could use uglifyjs (here in Debian is node-uglify) instead.

Done, just committed the change from to yui-compressor to uglifyjs

> That's what I can tell you so far. I checked everything else and it
> seems good :-)

Let me know if there is anything else you'd like me to change.
I'm still wondering if having the full upstream source code in master
is correct or not...

   +Emilien