[Pkg-javascript-devel] Feedback on new Lazy Load Plugin for jQuery package?

Jose Luis Rivas ghostbar at debian.org
Tue Feb 14 20:14:13 UTC 2012


On 02/14/2012 03:21 PM, Emilien Klein wrote:
> Hi Jose Luis,
> 2012/2/14 Jose Luis Rivas <joseluis at rivco.net>:
>> On 02/12/2012 06:05 PM, Emilien Klein wrote:
>>
>>> Hey David and Jose Luis
>>>
>>> I got SSH access, created the repo on the server, and I believe I've
>>> managed to create my first ever git repo properly and push it to
>>> git.d.o [0]. I'm still a bit confused on the content of the different
>>> branches, in particular of master:
>>> jQuery's master branch only contains the debian directory, whereas my
>>> master contains the entire upstream content as well...
>>>
>>> Anyway, please let me know what I might need to have to change.
>>>
>>> Good night!
>>>    +Emilien
>>>
>>
>> Hey Emilian, I just checked your package
> 
> Thanks!
> 
>> and as a first thing I do I
>> build it in my cowbuilder. I got this error:
>>
>> 8<---
>> mkdir -p debian/tmp-build
>> yui-compressor jquery.lazyload.js -o debian/tmp-build/jquery.lazyload.min.js
>> Error occurred during initialization of VM
>> Could not reserve enough space for object heap
>> Could not create the Java virtual machine.
>> make[1]: *** [override_dh_auto_build] Error 1
>> make[1]: Leaving directory `/tmp/buildd/jquery-lazyload-1.7.0'
>> make: *** [build] Error 2
>> dpkg-buildpackage: error: debian/rules build gave error exit status 2
>> E: Failed autobuilding of package
>> --->8
>>
>> You could use uglifyjs (here in Debian is node-uglify) instead.
> 
> Done, just committed the change from to yui-compressor to uglifyjs
> 
>> That's what I can tell you so far. I checked everything else and it
>> seems good :-)
> 
> Let me know if there is anything else you'd like me to change.
> I'm still wondering if having the full upstream source code in master
> is correct or not...

Yep, that's tottaly correct. You should keep `master` with upstream +
/debian, `upstream` with just upstream and `pristine-tar` with help of
pristine-tar binary. That's at least how is done in pkg-perl (where I
come from)

I'll check again your package in a few hours, right now my internet link
is not very good and I need to connect to a VPS to work on packages.
-- 
Jose Luis Rivas - GPG: 0x7C4DF50D / 0xCACAB118
The Debian Project Developer -- http://ghostbar.ath.cx
Barquisimeto, Venezuela

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20120214/926a0d55/attachment-0001.pgp>


More information about the Pkg-javascript-devel mailing list