[Pkg-javascript-devel] Review of libv8-i18n

[Jonas Smedegaard]

Hi (mostly) Jérémy,

You asked me on IRC to review libv8-i18n, and I now found time to do so:

Copyright file lacks Upstream-Source URL(s) and Upstream-Contact 
address(es).

Copyright file lacks a Comment: referencing actual Apache 2.0 license 
below /usr/share/common-licenses.

Patch 2002 changes to include "v8.h" - but if that's system shared 
header I suspect that should instead be <v8.h>.

Seems irrelevant to me to mention origin or reverse dependencies in long 
description: I suggest dropping 2nd paragraph.

Makes more sense to me to first introduce what libv8 is and then that 
this package is an extension to it: I suggest swapping those two 
paragraphs in long description.

Please use anonvcs.debian.org URL in Vcs-Browser field.

I recommend using d-shlibs to handle installation of library files and 
resolve library-related dependencies.

I suggest re-wrapping control file long descriptions and copyright file 
License fields at 72 chars (not 80 chars).

Did you consider using symbols file to track API/ABI changes instead of 
simply relying on upstream version for that?  Especially since you 
really do not use upstream releases but VCS snapshots: Seems unlikely to 
me that SONAME should be bumped exactly when upstream bumps version 
number, rather than such changes appearing at some earlier VCS commit.

Would be good if you could have get-orig-source target include a rule to 
generate a Changelog.svn file, e.g. using 
/usr/share/doc/subversion/examples/gnuify-changelog.pl.gz (but since it 
is forbidden to rely on /usr/share/doc to exist, that script should then 
be included in debian/ subdir).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20120331/fde3e90c/attachment.pgp>