[Pkg-javascript-devel] Bug#705393: [RFR] templates://sipml5/{sipml5-web-phone.templates}

Christian PERRIER bubulle at debian.org
Mon Apr 22 04:51:09 UTC 2013 

Please find, for review, the debconf templates and packages descriptions for the sipml5 source package.

This review will last from Monday, April 22, 2013 to Thursday, May 02, 2013.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- sipml5.old/debian/sipml5-web-phone.templates	2013-04-14 11:27:07.222913359 +0200
+++ sipml5/debian/sipml5-web-phone.templates	2013-04-18 07:48:08.294045748 +0200
@@ -1,14 +1,14 @@
 Template: sipml5-web-phone/webserver
 Type: boolean
 Default: true
-_Description: Automatically configure apache2?
+_Description: Automatically configure Apache for Sipml5?
  The package will be unavailable until a web server is configured.
- Automatic configuration can be performed for the Apache 2 web server.
+ Automatic configuration can be performed for the Apache web server.

There is imho no need to specifiy this is "apache2" we configure.

We also need to specify for what it is to be configured, in case the
question comes in the middle of a bunch of other questions.

 
 Template: sipml5-web-phone/reload
 Type: boolean
 Default: true
-_Description: Reload apache2 configuration?
+_Description: Reload Apache configuration?
  In order to activate the new configuration, the web server needs
  to reload its configuration. If you choose not to do this automatically,
  you should do so manually at the first opportunity.

Same rationale.

--- sipml5.old/debian/control	2013-04-14 11:27:07.222913359 +0200
+++ sipml5/debian/control	2013-04-18 07:52:08.565973981 +0200
@@ -14,10 +14,10 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}
 Recommends: javascript-common
-Description: JavaScript implementation of a WebRTC SIP video phone
- HTML5 SIP client entirely written in JavaScript for integration in
- any web site, incude a blog, CMS or web application.  Requires
- a modern WebRTC capable web browser and a SIP server/proxy supporting
+Description: WebRTC SIP video phone - Javascript library
+ Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
+ any web site, such as a blog, CMS or web application. It requires
+ a WebRTC-capable web browser and a SIP server/proxy supporting
  the SIP over WebSockets transport.
  .
  This package provides the JavaScript library for use in web sites

Specifying that it is written in Javascript is probably not useful, at
least in the short description. Indeed, I propose to specify it but in
the "specific" part of the description.

In the long description, use the standard "Foo is <blahblah>"
style. And, here, explain that it is entirely written in Javascript.

"WebRTC-capable" : use hyphen.

Other changes below are just harmonization with this.

@@ -28,10 +28,10 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}
 Recommends: libjs-sipml5
-Description: JavaScript implementation of a WebRTC SIP video phone - API docs
- HTML5 SIP client entirely written in JavaScript for integration in
- any web site, incude a blog, CMS or web application.  Requires
- a modern WebRTC capable web browser and a SIP server/proxy supporting
+Description: WebRTC SIP video phone - API documentation
+ Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
+ any web site, such as a blog, CMS or web application. It requires
+ a WebRTC-capable web browser and a SIP server/proxy supporting
  the SIP over WebSockets transport.
  .
  This package provides the API documentation for the JavaScript library.
@@ -41,10 +41,10 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}, libjs-sipml5, libjs-jquery, apache2 | lighttpd | httpd
 Recommends: repro, resiprocate-turn-server
-Description: Basic SIP video-phone web page based on WebRTC
- HTML5 SIP client entirely written in JavaScript for integration in
- any web site, incude a blog, CMS or web application.  Requires
- a modern WebRTC capable web browser and a SIP server/proxy supporting
+Description: WebRTC SIP video-phone - sample web page
+ Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
+ any web site, such as a blog, CMS or web application. It requires
+ a WebRTC-capable web browser and a SIP server/proxy supporting
  the SIP over WebSockets transport.
  .
  This package provides a basic HTML implementation of a phone that

-- 


-------------- next part --------------
Template: sipml5-web-phone/webserver
Type: boolean
Default: true
_Description: Automatically configure Apache for Sipml5?
 The package will be unavailable until a web server is configured.
 Automatic configuration can be performed for the Apache web server.

Template: sipml5-web-phone/reload
Type: boolean
Default: true
_Description: Reload Apache configuration?
 In order to activate the new configuration, the web server needs
 to reload its configuration. If you choose not to do this automatically,
 you should do so manually at the first opportunity.

-------------- next part --------------
--- sipml5.old/debian/sipml5-web-phone.templates	2013-04-14 11:27:07.222913359 +0200
+++ sipml5/debian/sipml5-web-phone.templates	2013-04-18 07:48:08.294045748 +0200
@@ -1,14 +1,14 @@
 Template: sipml5-web-phone/webserver
 Type: boolean
 Default: true
-_Description: Automatically configure apache2?
+_Description: Automatically configure Apache for Sipml5?
  The package will be unavailable until a web server is configured.
- Automatic configuration can be performed for the Apache 2 web server.
+ Automatic configuration can be performed for the Apache web server.
 
 Template: sipml5-web-phone/reload
 Type: boolean
 Default: true
-_Description: Reload apache2 configuration?
+_Description: Reload Apache configuration?
  In order to activate the new configuration, the web server needs
  to reload its configuration. If you choose not to do this automatically,
  you should do so manually at the first opportunity.
--- sipml5.old/debian/control	2013-04-14 11:27:07.222913359 +0200
+++ sipml5/debian/control	2013-04-18 07:52:08.565973981 +0200
@@ -14,10 +14,10 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}
 Recommends: javascript-common
-Description: JavaScript implementation of a WebRTC SIP video phone
- HTML5 SIP client entirely written in JavaScript for integration in
- any web site, incude a blog, CMS or web application.  Requires
- a modern WebRTC capable web browser and a SIP server/proxy supporting
+Description: WebRTC SIP video phone - Javascript library
+ Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
+ any web site, such as a blog, CMS or web application. It requires
+ a WebRTC-capable web browser and a SIP server/proxy supporting
  the SIP over WebSockets transport.
  .
  This package provides the JavaScript library for use in web sites
@@ -28,10 +28,10 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}
 Recommends: libjs-sipml5
-Description: JavaScript implementation of a WebRTC SIP video phone - API docs
- HTML5 SIP client entirely written in JavaScript for integration in
- any web site, incude a blog, CMS or web application.  Requires
- a modern WebRTC capable web browser and a SIP server/proxy supporting
+Description: WebRTC SIP video phone - API documentation
+ Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
+ any web site, such as a blog, CMS or web application. It requires
+ a WebRTC-capable web browser and a SIP server/proxy supporting
  the SIP over WebSockets transport.
  .
  This package provides the API documentation for the JavaScript library.
@@ -41,10 +41,10 @@
 Multi-Arch: foreign
 Depends: ${misc:Depends}, libjs-sipml5, libjs-jquery, apache2 | lighttpd | httpd
 Recommends: repro, resiprocate-turn-server
-Description: Basic SIP video-phone web page based on WebRTC
- HTML5 SIP client entirely written in JavaScript for integration in
- any web site, incude a blog, CMS or web application.  Requires
- a modern WebRTC capable web browser and a SIP server/proxy supporting
+Description: WebRTC SIP video-phone - sample web page
+ Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
+ any web site, such as a blog, CMS or web application. It requires
+ a WebRTC-capable web browser and a SIP server/proxy supporting
  the SIP over WebSockets transport.
  .
  This package provides a basic HTML implementation of a phone that
-------------- next part --------------
Source: sipml5
Section: web
Priority: optional
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel at lists.alioth.debian.org>
Uploaders: Daniel Pocock <daniel at pocock.com.au>
Build-Depends: debhelper (>= 9), yui-compressor, jsdoc-toolkit, po-debconf
Standards-Version: 3.9.3
Homepage: http://sipml5.org
Vcs-Browser: http://git.debian.org/?p=pkg-javascript/sipml5.git
Vcs-Git: git://git.debian.org/git/pkg-javascript/sipml5.git

Package: libjs-sipml5
Architecture: all
Multi-Arch: foreign
Depends: ${misc:Depends}
Recommends: javascript-common
Description: WebRTC SIP video phone - Javascript library
 Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
 any web site, such as a blog, CMS or web application. It requires
 a WebRTC-capable web browser and a SIP server/proxy supporting
 the SIP over WebSockets transport.
 .
 This package provides the JavaScript library for use in web sites
 or for other packages that require it.

Package: libjs-sipml5-doc
Architecture: all
Multi-Arch: foreign
Depends: ${misc:Depends}
Recommends: libjs-sipml5
Description: WebRTC SIP video phone - API documentation
 Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
 any web site, such as a blog, CMS or web application. It requires
 a WebRTC-capable web browser and a SIP server/proxy supporting
 the SIP over WebSockets transport.
 .
 This package provides the API documentation for the JavaScript library.

Package: sipml5-web-phone
Architecture: all
Multi-Arch: foreign
Depends: ${misc:Depends}, libjs-sipml5, libjs-jquery, apache2 | lighttpd | httpd
Recommends: repro, resiprocate-turn-server
Description: WebRTC SIP video-phone - sample web page
 Simpl5 is an HTML5 SIP client entirely written in JavaScript for integration in
 any web site, such as a blog, CMS or web application. It requires
 a WebRTC-capable web browser and a SIP server/proxy supporting
 the SIP over WebSockets transport.
 .
 This package provides a basic HTML implementation of a phone that
 can be published through a web server such as Apache.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20130422/2ab76af1/attachment.pgp>

More information about the Pkg-javascript-devel mailing list