[Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu

[Emilien Klein]

Hi François-Régis,

2014-04-01 23:08 GMT+02:00 François-Régis <frv-debian at miradou.com>:
> Hi dears pkg-javascript members,
>
> I've pushed jquery-simpletreemenu on anonscm [1], could someone have a
> look at it and tell me how horrible it is ?

- d/copyright:
  * inconsistent name of upstream contact (Freytag vs. Freitag).
According to github, it's "Simon Freytag"
  * Include upstream email address as part of Upstream-Contact (from
his website: simon at freytag.org.uk)
  * you have to mention the copyright on the debian/* files (you can
use same-as-upstream, but have to list yourself as copyright holder)
  * Upstream-Name is incorrect (likely "Simple Tree Menu")
  * Where did you get the year 2010 as start of copyright? The git
repo starts in 2012 with a mention of a previous manual zip file.

- d/upstream-changelog: the file ends with "Version 1.5.0: Moved to
github, effectively ending this changelog; changes will now just be
the [git log]"
Do you plan to update it with the actual git log? Otherwise I'm not
sure this file brings much benefit in including in the Debian package,
as it will only be a forever outdated changelog.

    +Emilien