[Pkg-javascript-devel] Debian node-express

[Jérémy Lal]

Le mercredi 30 avril 2014 à 00:46 +0200, Jonas Smedegaard a écrit :
> Quoting Jérémy Lal (2014-04-29 16:03:04)
> > Le mardi 29 avril 2014 à 15:31 +0200, Jonas Smedegaard a écrit :
> >>> I reverted package to cdbs. Since I do not really know it, can you 
> >>> please take a look at debian/rules ensuring everything is correct?
> >>
> >> Certainly!
> 
> I have taken a look now - a thorough one.

Thank you for that.

> Hope you agree with the changes I made.  Don't hesitate to ask if in 
> doubt about any of it.

Damn copyrighted ICC profile in the png file !
I didn't build the package before, is this something caught by
copyright-check ? lintian ?

About package.json:

My idea was to include package.json as part of the module, because

* it is common practice to `require('./package.json').version` inside a
module, among other things

* eventually, being able to propose a "npm-integration" debian package,
much like "rubygems-integration", would require access to package.json
files.

* looking for package.json is hard-wired into nodejs, it's really not
only about npm.

Granted, if you disagree that won't prevent node-express from running.

If you agree then it's only natural to keep the same relative tree as
the one expected by package.json (that's why the "lib/" dir was
installed in the particular case of express, instead of the files
within). It saves a patch...


> > In case you're missing the time, i can review and upload later today.
> 
> I suspect you couldn't (or shouldn't) upload yet: At least node-parseurl 
> is missing (I haven't checked further).

Yes, it's waiting in NEW.

Jérémy.