[Pkg-javascript-devel] rickshaw_1.4.6-1_amd64.changes REJECTED

[Gergely Nagy]

Dear maintainer!

While processing your upload of rickshaw 1.4.6-1, I noticed a couple
of oddities and mistakes:

 - tutorial/vendor/prettify/prettify.js is under Apache-2.0, (C) 2006
   Google, yet, is not documented in debian/copyright. Even if unused,
   all files should be covered. And d/copyright wrongfully claims this
   file is under the MIT license, due to the Files: * section.

   vendor/d3.* are not under the MIT license, either (they're BSD,
   according to the upstream homepage)

   (This is the reason for the REJECT)

 - Instead of patching the Makefile (twice!), how about patching only
   the npm install bits out, and using this in debian/rules:

   override_dh_auto_install:
   	${MAKE} CSS_MIN=cleancss JS_MIN=uglifyjs JS_HINT=true

   (Not tested, but should work, and is less likely to conflict with
   upstream changes in the future.)

===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.