[Pkg-javascript-devel] can we use my fork of node-findit?

[Jérémy Lal]

Le mardi 14 octobre 2014 à 21:49 -0700, Andrew Kelley a écrit :
> I fixed all the bugs in node-findit and submitted the patch to upstream:
> https://github.com/substack/node-findit/pull/34
> 
> But I am afraid that upstream will not accept my code and I do not have
> time to wait. So I have forked findit to findit2 and started using that in
> my modules, because it fixes bugs.
> 
> So now my question is, when packaging these modules, may I update
> node-findit, keeping the same package name, but use my fork instead?
> 
> It keeps the same API and fixes all the findit bugs. Further, the only
> packages that depend on findit so far are mine:
> 
> $ apt-cache rdepends  node-findit
> node-findit
> Reverse Depends:
>   groovebasin
> 
> So far only groovebasin depends on node-findit. And this update happened
> upstream in groovebasin:
> 
> groovebasin
>   findit -> findit2
>   connect-static
>     findit -> findit2
>   multiparty
>     findit -> findit2
> 
> So that's 3 places that need the fork instead of the original, and 0 places
> that need the original.
> 
> What should I do?

Since both have same API, i'd add your patches as quilt patches to
node-findit that is already in debian and add a binary package
node-findit2 (symlinking /usr/lib/nodejs/findit to findit2).

Or the reverse, change upstream and add binary node-findit to
node-findit2.

Jérémy.