[Pkg-javascript-devel] Bug#792862: RFA: acorn

[Olivier Magloire]

Hi there

I'd like to help out here.

Building the package with upstream 1.0.0 fails with this error:

"
nodejs test/run.js

module.js:340
    throw err;
          ^
Error: Cannot find module '..'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous>
(/home/sheepherd/pkg/acorn-1.0.0/test/tests.js:7:15)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
debian/rules:30: recipe for target 'override_dh_auto_test' failed
"

The mentioned script module.js is part of the nodejs package
(node-v0.10.38/lib/module.js) and boils down to following code.

"
Module._resolveFilename = function(request, parent) {
  if (NativeModule.exists(request)) {
    return request;
  }
  
  var resolvedModule = Module._resolveLookupPaths(request, parent);
  var id = resolvedModule[0];
  var paths = resolvedModule[1];

  // look up the filename first, since that's the cache key.
  debug('looking for ' + JSON.stringify(id) +
        ' in ' + JSON.stringify(paths));

  var filename = Module._findPath(request, paths);
  if (!filename) {
    var err = new Error("Cannot find module '" + request + "'");
    err.code = 'MODULE_NOT_FOUND';
    throw err;
  }
  return filename;
};
"

It looks like the reference test/run.js is correct, the file also
exists. 
Could this be a bug in run.js?
A diff between run.js 0.12.0 and 1.0.0 results in:
"
sheepherd at debian-pkg:~/pkg$ diff run.js_0.12.0 run.js_1.0.0 
2c2
<   var driver;
---
>   var driver, acorn;
7a8,10
>     require("babelify/node_modules/babel-core/register")
>     acorn = require("../src")
>     require("../src/loose")
9a13
>     acorn = window.acorn;
50c54
<         parse: (typeof require === "undefined" ? window.acorn :
require("../acorn.js")).parse
---
>         parse: acorn.parse
55c59
<         parse: (typeof require === "undefined" ? window.acorn :
require("../acorn_loose")).parse_dammit,
---
>         parse: acorn.parse_dammit,
"

I also disabled all minify lines in the debian/rules file, because these
files don't exist anymore.
Are they replaced with anything else?

        # Minify Javascript
        # uglifyjs -o acorn.min.js acorn.js
        # uglifyjs -o acorn_loose.min.js acorn_loose.js
        # uglifyjs -o walk.min.js util/walk.js


-- 
Greets
Olivier Magloire