[Pkg-javascript-devel] enabling tests on node-cliui

[Paolo Greppi]

I have investigated and found that the same fix for node-chalk
(https://lists.alioth.debian.org/pipermail/pkg-javascript-devel/2016-November/015905.html)
fixes the issue here.

No need to path to skip tests.

This package is basically ready for release with the tests enabled.
Would Jérémy sponsor its upload ?

Paolo

On 29/11/2016 13:59, Jérémy Lal wrote:
> 2016-11-29 13:24 GMT+01:00 Paolo Greppi <paolo.greppi at libpf.com>:
>> Since chai is in Debian I have re-enabled the original tests in
>> node-cliui, there is one failing and 23 passing:
>>
>>   1) cliui layoutDSL ignores ansi escape codes when measuring padding:
>>
>>       AssertionError: expected [ Array(5) ] to deeply equal [ Array(5) ]
>>       + expected - actual
>>
>>          "  |",
>>          "  __|   __|  |   |   _ \\",
>>          "  |    |     |   |   __/",
>>          " \\__| _|    \\__,_| \\___|",
>>       -  ""
>>       +  "                         "
>>        ]
>>
>>       at Context.<anonymous>
>> (/root/debian/node-cliui/node-cliui/test/cliui.js:441:17)
>>       at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:223:21)
>>       at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:216:7)
>>       at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:373:10)
>>       at /usr/lib/nodejs/mocha/lib/runner.js:451:12
>>       at next (/usr/lib/nodejs/mocha/lib/runner.js:298:14)
>>       at /usr/lib/nodejs/mocha/lib/runner.js:308:7
>>       at next (/usr/lib/nodejs/mocha/lib/runner.js:246:23)
>>       at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:275:5)
>>       at processImmediate [as _immediateCallback] (timers.js:383:17)
>>
>> Has anybody an idea why ?
> 
> (please push commits so that we can sbuild easily).
> 
> It works locally, but not in a clean sbuild chroot.
> No idea why. Something with how much console features are supported.
> I'm interested to find out why !
> 
>> Or should I just skip the failing test using the mocha skip
>> chain-function (http://mochajs.org/#inclusive-tests) ?
> 
> Good idea - it's better than a patch !
> 
> Jérémy


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20161202/d7329db5/attachment.sig>