[Pkg-javascript-devel] Bug#815745: node-tap: diff for NMU version 0.7.1-1.1

[Gianfranco Costamagna]

Package: node-tap
Version: 0.7.1-1
Severity: important

Dear maintainer,

I've prepared an NMU for node-tap (versioned as 0.7.1-1.1) and
uploaded it to DELAYED/15. Please feel free to tell me if I
should delay it longer.


I'm setting to important, and uploading because I'm pretty sure you didn't 

build in a clean environment, the package is not binNMU safe, and this is preventing node-core-util-is
from being built correctly (and makes the package useless on ubuntu unless you chmod it)

TLTR: doing chmod in dh_install is wrong, because after the call, dh_fixperms will reset the bits again.

you have to overrride_dh_fixperms instead.

(I'll upload with a "Closes: this bug" added on changelog)


Regards.


diff -Nru node-tap-0.7.1/debian/changelog node-tap-0.7.1/debian/changelog
--- node-tap-0.7.1/debian/changelog     2015-08-31 04:30:08.000000000 +0200
+++ node-tap-0.7.1/debian/changelog     2016-02-24 09:59:40.000000000 +0100
@@ -1,3 +1,9 @@
+node-tap (0.7.1-1.1) unstable; urgency=medium
+
+  * fix tap executable permission override.
+
+ -- Gianfranco Costamagna <locutusofborg at debian.org>  Wed, 24 Feb 2016 09:59:26 +0100
+
node-tap (0.7.1-1) unstable; urgency=medium

* Team upload.
diff -Nru node-tap-0.7.1/debian/rules node-tap-0.7.1/debian/rules
--- node-tap-0.7.1/debian/rules 2015-08-31 04:09:24.000000000 +0200
+++ node-tap-0.7.1/debian/rules 2016-02-24 09:59:54.000000000 +0100
@@ -7,8 +7,8 @@
%:
dh $@

-override_dh_install:
-       dh_install
+override_dh_fixperms:
+       dh_fixperms
chmod a+x debian/node-tap/usr/lib/nodejs/tap/bin/*.js

override_dh_auto_test: