[Pkg-javascript-devel] Bug#831161: libv8-3.14: FTBFS with GCC 6: ../src/spaces.h:837:39: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare]

[Lucas Nussbaum]

Source: libv8-3.14
Version: 3.14.5.8-10
Severity: serious
Tags: stretch sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20160713 qa-ftbfs
Justification: FTBFS with GCC 6 on amd64

Hi,

During a rebuild of all packages in sid using the gcc-defaults package
available in experimental to make GCC default to version 6, your package failed
to build on amd64. For more information about GCC 6 and Stretch, see:
- https://wiki.debian.org/GCC6
- https://lists.debian.org/debian-devel-announce/2016/06/msg00007.html

Relevant part (hopefully):
>   g++ '-DENABLE_DEBUGGER_SUPPORT' '-DENABLE_EXTRA_CHECKS' '-DV8_TARGET_ARCH_X64' '-DBUILDING_V8_SHARED' '-DV8_SHARED' -I../src  -Wall -Werror -W -Wno-unused-parameter -Wnon-virtual-dtor -pthread -fno-rtti -fno-exceptions -pedantic -ansi -fvisibility=hidden -fPIC -fdata-sections -ffunction-sections -O3  -MMD -MF /«PKGBUILDDIR»/out/x64.release/.deps//«PKGBUILDDIR»/out/x64.release/obj.target/v8_base/src/spaces.o.d.raw -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -c -o /«PKGBUILDDIR»/out/x64.release/obj.target/v8_base/src/spaces.o ../src/spaces.cc
> In file included from ../src/mark-compact.h:32:0,
>                  from ../src/incremental-marking.h:33,
>                  from ../src/heap.h:35,
>                  from ../src/elements.h:33,
>                  from ../src/objects-inl.h:38,
>                  from ../src/v8.h:60,
>                  from ../src/spaces.cc:28:
> ../src/spaces.h: In member function 'bool v8::internal::CodeRange::exists()':
> ../src/spaces.h:837:39: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare]
>    bool exists() { return this != NULL && code_range_ != NULL; }
>                                        ^
> ../src/spaces.h: In member function 'bool v8::internal::CodeRange::contains(v8::internal::Address)':
> ../src/spaces.h:839:5: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare]
>      if (this == NULL || code_range_ == NULL) return false;
>      ^~
> cc1plus: all warnings being treated as errors
> make[2]: *** [/«PKGBUILDDIR»/out/x64.release/obj.target/v8_base/src/spaces.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2016/07/13/libv8-3.14_3.14.5.8-10_unstable_gcc6.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.