[Pkg-javascript-devel] Bug#836722: Bug#836722: Bug#836722: needs yargs as a dependency

[Jonas Smedegaard]

Quoting Pirate Praveen (2016-11-28 11:32:00)
> Control: block -1 by 846076
> 
> On Sun, 27 Nov 2016 14:08:15 +0530 Pirate Praveen <praveen at debian.org>
> wrote:
> > yargs is in NEW and we can upload a new version once it is accepted.
> > 
> Hi Jonas,
> 
> I have prepared the package in git and it is almost ready for upload.
> Can you review and fix these two warnings and upload it?
> 
> W: node-uglify: manpage-has-useless-whatis-entry
> usr/share/man/man1/uglifyjs.1.gz
> W: node-uglify: script-not-executable
> usr/lib/nodejs/uglify-js/bin/extract-props.js
> 
> I'm not too familiar with cdbs, on plain debhelper I could use dh_fixperms

CDBS runs dh_fixperms.  This line in dbian/rules instructs dh_fixparms 
to skip nodejs library path, if that is what you wanted to do:

DEB_FIXPERMS_EXCLUDE_node-uglify = usr/lib/nodejs

I don't follow how dh_fixperms is relevant here, however: I believe 
dh_fixperms can only be told to _skip_ fixing some permissions, not be 
educated to e.g. treat /usr/lib/* same as /usr/bin.

Seems to me that a simple chmod command is the right thing to use.  I do 
that now, and try release the package - but you are quite welcome to 
suggest other approaches, or adapt the package yourself.

Thanks for all your great work!


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private